Add Vision API connection. #2167
Conversation
googlebot
added
the
cla: yes
|
Looks fine but Travis is failing. |
| API_VERSION = 'v1' | ||
| """The version of the API, used in building the API call's URL.""" | ||
|
|
||
| API_URL_TEMPLATE = '{api_base_url}/{api_version}{path}' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
It was failing, I believe because I didn't have the RST for it in there. Also I added an API URL example. |
scripts/generate_json_docs.py
Outdated
| 'streaming': [], | ||
| 'translate': [] | ||
| 'translate': [], | ||
| 'vision': [] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM once Travis passes though you should squash if not too inconvenient |
daspecster
force-pushed
the
vision-connection
branch
from
38476b5 to
00c05e9
Compare
|
Wow travis...what's the deal? |
|
@daspecster I'm guessing the conflict is in |
|
Yeah Travis has been slow. And in the 35 minutes since you posted that, I did give you a conflict. Sorry. |
Add RST and ignore vision.__init__. Add API URL example. Add vision to TOCs. Add trailing comma. Add vision/connection to toc.json.
daspecster
force-pushed
the
vision-connection
branch
from
00c05e9 to
2cf3a90
Compare
|
Conflict resolved....back to waiting on travis. |
|
Finally! |
4 participants
As per a conversation about small PR's with @dhermes, here is Vision's connection class.
This is pretty simple, just adding the needed scope.