-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sphinx as a dependency for linting #2019
Conversation
e3a5018
to
554285b
Compare
lgtm |
I am 👎 on the quick merge without a more in-depth investigation. I'm pretty sure this snuck in because our |
Sorry, I can revert. I looked and the offending line is https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/scripts/verify_included_modules.py#L119 Which is called from https://github.com/GoogleCloudPlatform/gcloud-python/blob/master/tox.ini#L153 actually and not the pep8 stuff AFAICT. |
Also sorry if you think it was too hasty but it did fix my PR. |
Also, by Might be a pycodestyle bug? I tried it before when I did the pep8->pycodestyle conversion and it broke then too. |
We can talk more here #2020 |
That is a failure in pylint, not pycodestyle: it is trying to check |
First seen #1946 (comment)
Not sure how this got through?