-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making HappyBase enabled/disabled checks into no-ops. #1997
Conversation
LGTM pending Travis. |
LGTM Are there any concerns about non-actionable warning messages, since there's nothing a user can do to remove the warnings, short of not calling the functions? I guess since these actions are administrative rather than data-oriented, they should be called rather rarely, so it shouldn't clog up their logs too much, and they ought to know that they're no-ops, so I think this is fine. Thanks for making the change! |
Also fixing some lint related errors (not using arguments and not using self).
LGTM |
@mbrukman Implemented your updates to the language. |
LGTM, thanks! |
Fixes #1989.
/cc @mbrukman @tswast