Skip to content

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jun 20, 2016

See #1863.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2016
@dhermes
Copy link
Contributor

dhermes commented Jun 20, 2016

Sorry for n00b question, what is WAG?

@dhermes
Copy link
Contributor

dhermes commented Jun 20, 2016

LGTM

@tseaver
Copy link
Contributor Author

tseaver commented Jun 20, 2016

@dhermes "WAG" -> "wild-assed guess".

@tseaver tseaver merged commit fd8ff5a into googleapis:master Jun 20, 2016
@tseaver tseaver deleted the appveyor-grpc-issue-6939-wag branch June 20, 2016 23:19
@tseaver
Copy link
Contributor Author

tseaver commented Jun 20, 2016

Now we cross our fingers and think Good Thoughts(tm).

@tseaver
Copy link
Contributor Author

tseaver commented Jun 20, 2016

Horsefeathers. My cmd.exe fu has withered away like the Marxist state.

@dhermes
Copy link
Contributor

dhermes commented Jun 21, 2016

@dhermes
Copy link
Contributor

dhermes commented Jun 21, 2016

%CMD_IN_ENV% if "%INSTALL_GRPC%"=="1" (pip install grpcio)
Using default MSVC build environment for 64 bit architecture
Executing: if ""=="1" (pip install grpcio)
'if' is not recognized as an internal or external command,
operable program or batch file.
Command exited with code 1

@tseaver
Copy link
Contributor Author

tseaver commented Jun 21, 2016

If we drop testing Python 2.6 on Appveyor, I think we can get away with installing grpcio and the gax-* packages unconditionally.

@dhermes
Copy link
Contributor

dhermes commented Jun 21, 2016

👍 Dropping Windows Python 2.6 testing is A-OK with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. packaging testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants