Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 0.16.0 #1854

Merged
merged 1 commit into from
Jun 20, 2016
Merged

Conversation

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2016
@daspecster
Copy link
Contributor Author

@tseaver, what do you think about merging in #1815 and #1844 for this release?

@daspecster
Copy link
Contributor Author

@tseaver, #1844 got merged and I'm inclined to leave #1813 out unless we can merge it today. But I'm not sure about #1815?

@tseaver
Copy link
Contributor

tseaver commented Jun 15, 2016

I just merged #1815. I think we should merge #1813 today, and then make a release.

@tseaver
Copy link
Contributor

tseaver commented Jun 15, 2016

$ git log -1 --pretty=%H
a74ed9e3e8a8abbe46ca7968ed21cb9a1762dda9
$ git log 0.15.0..HEAD | grep 'Merge pull request ' |  awk -F ' ' '{print $4}' | sort

yields:

#1815
#1816
#1843
#1848
#1851
#1855
#1861

@tseaver
Copy link
Contributor

tseaver commented Jun 15, 2016

0.16.0 Release Notes

Core

Datastore

Storage

Pubsub

Bigtable

Logging

@daspecster
Copy link
Contributor Author

@tseaver also I made a release draft for 0.16.0 just fyi.

@daspecster
Copy link
Contributor Author

@tseaver, when I rerun

$ git log 0.15.0..HEAD | grep 'Merge pull request ' |  awk -F ' ' '{print $4}' | sort

I don't see the new PRs in there...#1813, #1860, #1844...possibly others?

Any ideas?

@tseaver
Copy link
Contributor

tseaver commented Jun 16, 2016

Have you merged your local master with upstream/master?

@daspecster
Copy link
Contributor Author

I rebased it.

Do they show up for you?

@tseaver
Copy link
Contributor

tseaver commented Jun 16, 2016

Also, "merge w/ squash commits" doesn't create a merge commit findable by that command line. I manually ran git log 0.15.0..HEAD and looked at the commits to uncover #1844, for instance.

@daspecster
Copy link
Contributor Author

Ah that's it! I did use the github squash merge and I didn't add "Merge pull request" to the commit message.

@daspecster
Copy link
Contributor Author

I left out #1860 since you mentioned it's not user facing really.

@tseaver I think once we get the GRPCIO 0.14.0 issues on appveyor and the docs generation working we can cut this release right?

@tseaver
Copy link
Contributor

tseaver commented Jun 16, 2016

I think once we get the GRPCIO 0.14.0 issues on appveyor and the docs generation working we can cut this release right?

SGTM

@tseaver
Copy link
Contributor

tseaver commented Jun 17, 2016

Is grpcio 0.14.0 expected to Just Work (TM) on Windows? Given my last comments on #1863, I'd say we could go ahead with our release even though Appveyor is broken.

@daspecster
Copy link
Contributor Author

@tseaver, is there any fallout we could be heading towards by releasing?

It looks like my credentials helper function errors if it doesn't have permissions. I can just catch that in an except so it fails more peacefully.

https://ci.appveyor.com/project/daspecster/gcloud-python/build/1.0.1.master/job/433qv2dtg3uq4a4t#L513

@tseaver
Copy link
Contributor

tseaver commented Jun 17, 2016

I'd say we can go ahead and release, unless @jgeewax thinks that the grpico-on-Windows bit from #1815 is a blocker.

@daspecster
Copy link
Contributor Author

@tseaver we could merge in #1868 to fix some of the appveyor issues but not all obviously.

@tseaver
Copy link
Contributor

tseaver commented Jun 20, 2016

Sounds good. The remaining failures will then be blocked on a fix for grpc/grpc#6939.

@daspecster
Copy link
Contributor Author

Ok, sounds like a plan. Is there anything we can do to help resolve that?

@tseaver
Copy link
Contributor

tseaver commented Jun 20, 2016

@daspecster I just updated the checklist to pull in #1870 and the need to fix #1869.

@tseaver
Copy link
Contributor

tseaver commented Jun 20, 2016

@daspecster #1874 reverts pubsub defaults to the safe JSON-over-HTTP. AFAIK, it would be the last change needed before merging here.

@daspecster
Copy link
Contributor Author

We should probably note this in the release notes.

@tseaver
Copy link
Contributor

tseaver commented Jun 20, 2016

@daspecster I just updated the release note above for pubsub.

@daspecster
Copy link
Contributor Author

Good to go then right?

@tseaver
Copy link
Contributor

tseaver commented Jun 20, 2016

Yup!

@daspecster daspecster merged commit 986302f into googleapis:master Jun 20, 2016
@daspecster daspecster deleted the cut-0.16.0 branch January 24, 2017 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants