-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial vision API addition. #1803
Conversation
_topicality = None | ||
_bounding_poly = None | ||
_locations = [] | ||
_properties = [] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
I'd prefer constants over strings, even if they semantically mean the same thing:
|
def as_dict(self): | ||
return { | ||
"image": self.image, | ||
"features": self.features |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Rather than writing and dumping all this code, please draft a Once we agree on something, try to land them feature by feature so review doesn't become unmanageable. (e.g. you couldn't just sent a tiny PR with the (PS I know I "broke the rules" in #1772 however the entire API is contained in three methods so I did it "on purpose" / was aware it was a bit of a brain dump.) |
@tseaver I totally agree and wish I had done that. |
Ok, I'll make a PR with just a vision-usage.rst and then we can talk about it there. |
In favor of #1809 ans subsequent. |
Fairly rough and a lot of conversation to be had.
Examples to play with