Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Filtering Query by key is also possible. #1632

Merged
merged 2 commits into from
Mar 18, 2016
Merged

Documentation: Filtering Query by key is also possible. #1632

merged 2 commits into from
Mar 18, 2016

Conversation

mgilson
Copy link
Contributor

@mgilson mgilson commented Mar 18, 2016

Update the documentation for add_filter to make it clear that filtering by key is also possible.

Update the documentation for `add_filter` to make it clear that filtering by key is also possible.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 18, 2016
Fixup for lint.
@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

LGTM

dhermes added a commit that referenced this pull request Mar 18, 2016
Documentation: Filtering Query by key is also possible.
@dhermes dhermes merged commit 49f18ed into googleapis:master Mar 18, 2016
@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

Thanks @mgilson. In the future, if possible, can you squash your changes into a single commit? I'd be happy to help show you how if the need arises (e.g. here the lint error caused you to have to add a newline).

@mgilson
Copy link
Contributor Author

mgilson commented Mar 18, 2016

@dhermes Sure. Sorry about that. I would have squashed it on this one, but I was doing all of my edits via the github editor and didn't realize the error until travis yelled at me. I wanted to make sure travis was happy with the second commit before I rebased and force-pushed -- But by the time I got back, you had already merged.

@dhermes
Copy link
Contributor

dhermes commented Mar 18, 2016

No worries. I didn't want to burden you with having a checkout. I appreciate the quick fix!

@tseaver tseaver added the api: datastore Issues related to the Datastore API. label Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants