Moving all Bigtable row filters into their own module. #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the process also lowering the line limits to levels before they were raised to accomodate the final changes to the Bigtable Row implementations.
googlebot
added
the
cla: yes
This was referenced Mar 11, 2016
| @@ -200,7 +200,7 @@ no-space-check = | |||
| # Maximum number of lines in a module | |||
| # DEFAULT: max-module-lines=1000 | |||
| # RATIONALE: API-mapping | |||
| max-module-lines=1593 | |||
| max-module-lines=1200 | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. My comment on the line limits is really just "arguing with the ref". |
dhermes
added a commit
that referenced
this pull request
Mar 11, 2016
Moving all Bigtable row filters into their own module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process also lowering the line limits to levels before they were raised to accomodate the final changes to the Bigtable Row implementations.