Adding HappyBase system tests for families and counters. #1595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -870,7 +870,7 @@ class _RegexFilter(RowFilter): | |||
| """ | |||
|
|
|||
| def __init__(self, regex): | |||
| self.regex = regex | |||
| self.regex = _to_bytes(regex) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
These tests exposed an issue with regex filters. When a protobuf bytes field received a unicode object, bad things happened.
dhermes
force-pushed
the
happybase-sys-test-counter
branch
from
15ca673
to
25f22ba
Compare
| @@ -119,7 +119,7 @@ class _RegexFilter(RowFilter): | |||
| """ | |||
|
|
|||
| def __init__(self, regex): | |||
| self.regex = regex | |||
| self.regex = _to_bytes(regex) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@tseaver PTAL |
|
@tseaver LGTY to merge? |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Mar 12, 2016
Adding HappyBase system tests for families and counters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests exposed an issue with regex filters. When a protobuf bytes field received a unicode object, bad things happened.