Skip to content

Avoid protobuf 3.0.0.b2.post1. #1571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2016
Merged

Avoid protobuf 3.0.0.b2.post1. #1571

merged 2 commits into from
Mar 4, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 4, 2016

See: #1570

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 4, 2016
@tseaver tseaver closed this Mar 4, 2016
@dhermes
Copy link
Contributor

dhermes commented Mar 4, 2016

Did you mean to close? I would say I couldn't verify the syntax for the != but I assume you ran it.

@tseaver
Copy link
Contributor Author

tseaver commented Mar 4, 2016

The syntax was right, but I ran into other stupidity, and lost the will to live. :)

@tseaver tseaver reopened this Mar 4, 2016
@dhermes
Copy link
Contributor

dhermes commented Mar 4, 2016

Branch has conflicts?

@dhermes
Copy link
Contributor

dhermes commented Mar 4, 2016

Also the CLA check is the only check that ran

tseaver added 2 commits March 4, 2016 13:38
@tseaver
Avoid protobuf 3.0.0.b2.post1.
2982c0a 
See:
#1570
@tseaver
Comment out custom py27 tox environment.
f91709b 
grpcio 0.13.0 is broken on UCS2 Python 2.7.
@tseaver
Copy link
Contributor Author

tseaver commented Mar 4, 2016

grpc/grpc#5280 defeated me. I need to back out the forced use of grpcio in the testenv:py27 section to move forward.

@tseaver
Copy link
Contributor Author

tseaver commented Mar 4, 2016

@dhermes PTAL

dhermes
dhermes reviewed Mar 4, 2016
View reviewed changes
tox.ini
PYTHONPATH =
# Until grpcio 0.13.1 ships, this environment is broken on UCS2 builds.
# See: https://github.com/grpc/grpc/issues/5280 and
# https://github.com/grpc/grpc/pull/5319

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 4, 2016

LGTM. One day gRPC will be able to play with the big kids :)

tseaver added a commit that referenced this pull request Mar 4, 2016
@tseaver
Merge pull request #1571 from tseaver/1570-avoid-protobuf-3.0.0b2.post1
69391eb 
Avoid protobuf 3.0.0.b2.post1.
@tseaver tseaver merged commit 69391eb into googleapis:master Mar 4, 2016
@tseaver tseaver deleted the 1570-avoid-protobuf-3.0.0b2.post1 branch March 4, 2016 20:26
@theacodes theacodes mentioned this pull request Mar 4, 2016
Merged
@dhermes dhermes mentioned this pull request Mar 8, 2016
Closed
@bgenchel
Copy link

bgenchel commented Aug 2, 2016

what is the actual fix here? brought here by #1570, saying the issue was fixed in this issue, but this conversation seems pretty unintelligible to me.

@dhermes
Copy link
Contributor

dhermes commented Aug 2, 2016

Our fix is just to avoid a b0rken version that the protobuf maintainers uploaded to PyPI.

If you have a stacktrace that seems to contradict, please post it on that issue or open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tseaver @dhermes @bgenchel @googlebot