Skip to content

#1555: reload missing properties before blob download #1559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2016
Merged

#1555: reload missing properties before blob download #1559

merged 3 commits into from
Mar 3, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 2, 2016

Cleaner alternative to PR #1556, with coverage.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Mar 2, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 2, 2016
@tseaver tseaver mentioned this pull request Mar 2, 2016
Closed
dhermes
dhermes reviewed Mar 2, 2016
View reviewed changes
gcloud/storage/blob.py
"""
client = self._require_client(client)
if self.media_link is None: # not yet loaded
self.reload()

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Mar 3, 2016

LGTM pending Travis

tseaver added a commit that referenced this pull request Mar 3, 2016
@tseaver
Merge pull request #1559 from tseaver/1555-reload_on_missing_media_link
cba090e 
#1555: reload missing properties before blob download
@tseaver tseaver merged commit cba090e into googleapis:master Mar 3, 2016
@tseaver tseaver deleted the 1555-reload_on_missing_media_link branch March 3, 2016 16:29
@theacodes theacodes mentioned this pull request Mar 4, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot