Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up bigquery usage docs #1469

Merged
merged 5 commits into from
Feb 15, 2016
Merged

Clean up bigquery usage docs #1469

merged 5 commits into from
Feb 15, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Feb 15, 2016

Uses #1468 as a base.

Match actual usage patterns.

Closes #1398, #1399.

@tseaver tseaver added docs api: bigquery Issues related to the BigQuery API. labels Feb 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2016
dhermes
dhermes reviewed Feb 15, 2016
View reviewed changes
docs/bigquery-usage.rst
@@ -279,8 +279,8 @@ List jobs for a project:
>>> from gcloud import bigquery
>>> client = bigquery.Client()
>>> jobs, token = client.list_jobs() # API request
>>> [(job.job_id, job.type, job.created, job.state) for job in jobs]
['e3344fba-09df-4ae0-8337-fddee34b3840', 'insert', (datetime.datetime(2015, 7, 23, 9, 30, 20, 268260, tzinfo=<UTC>), 'done')]
>>> [(job.nme, job.type, job.created, job.state) for job in jobs]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver mentioned this pull request Feb 15, 2016
Closed
@dhermes
Copy link
Contributor

dhermes commented Feb 15, 2016

Only remaining issue is self.__class__ vs. self (fine to leave as-is). I'd still like a property name other than type though. WDYT?

@tseaver
Copy link
Contributor Author

tseaver commented Feb 15, 2016

I'd still like a property name other than type though. WDYT?

7b085f4 renames it to job_type.

@dhermes
Copy link
Contributor

dhermes commented Feb 15, 2016

LGTM (pending Travis)

tseaver added a commit that referenced this pull request Feb 15, 2016
@tseaver
Merge pull request #1469 from tseaver/1398-1399-bigquery-usage-cleanup
02c5689 
Clean up bigquery usage docs
@tseaver tseaver merged commit 02c5689 into googleapis:master Feb 15, 2016
@tseaver tseaver deleted the 1398-1399-bigquery-usage-cleanup branch February 15, 2016 21:10
@tseaver tseaver mentioned this pull request Feb 15, 2016
Closed
@dhermes dhermes mentioned this pull request Feb 17, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot