Changing use of PUBSUB_HOST env. var. to PUBSUB_EMULATOR_HOST. #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Also changing how the variable is used. Now, pre-pending the protocol in front. (Assumes the user does something like `localhost:8888`.)
dhermes
force-pushed
the
pubsub-emulator-host
branch
from
9d45ce0
to
03dfdf7
Compare
| if emulator_host is None: | ||
| api_base_url = self.__class__.API_BASE_URL | ||
| else: | ||
| api_base_url = 'http://' + emulator_host |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 14, 2016
Changing use of PUBSUB_HOST env. var. to PUBSUB_EMULATOR_HOST.
|
@hbchai I also updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changing how the variable is used. Now, pre-pending the protocol in front. (Assumes the user does something like
localhost:8888.)/cc @hbchai