Treating DNS zone creation time as an RFC 3339 string. #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was previously assumed to be a float (seconds from the epoch). Also using core timestamp utilities in `dns` tests. Fixes googleapis#1362.
googlebot
added
the
cla: yes
|
@dhermes I added the zone using the developer console. For now, I only have a need to use the gcloud library for updating existing records. Thanks for the fast response! |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 14, 2016
Treating DNS zone creation time as an RFC 3339 string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was previously assumed to be a float (seconds from the epoch). Also using core timestamp utilities in
dnstests.Fixes #1362.
@kvdb I found I couldn't even create a managed zone to test if this was possible. How did you create your pre-existing zones? (I'm curious if you have a test domain or if you are actually using the service to manage DNS rules for a live domain.)