-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming datastore Batch.mutation to mutations. #1306
Conversation
@tseaver I opted to do less in this PR just so we could discuss. For example, I'm not sure if |
Does the protobuf in
Might we have made the |
There is no But, I was very much wanting to discuss, so this is good. RE: "lint-y noises". I don't think so. We may have inherited it? We even access |
A single what? |
Sorry I meant a single mutation. In
whereas in
Essentially, the |
Maybe |
The reason I ditched |
@tseaver Or we could just name it commit request or something like that? Since the |
Given that we don't have backward-/forward compatibility cocerns: if the objects which make up the to-be-named list attribute are all of type |
0949183
to
4bbeb49
Compare
@tseaver OK I updated the name. PTAL. |
LGTM |
This is towards the switch to `v1beta3` where the `Mutation` container no longer holds a list of insert/update/upsert/etc. mutations (as `Entity` pb's) but instead holds a single one. The list is moved onto the `CommitRequest` message definition. Plan to follow up with methods to abstract away getting the list of inserts, upserts, deletes, etc. as well as a method for adding a new mutation of a given type to the `changes` accumulator.
4bbeb49
to
4536cfb
Compare
Renaming datastore Batch.mutation to mutations.
This is towards the switch to
v1beta3
where theMutation
container no longer holds a list of insert/update/upsert/etc.
mutations (as
Entity
pb's) but instead holds a single one.The list is moved onto the
CommitRequest
message definition.Plan to follow up with methods to abstract away getting the
list of inserts, upserts, deletes, etc. as well as a method
for adding a new mutation of a given type to the
changes
accumulator.