Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1260: Expose 'jobs/list' results #1279

Merged
merged 7 commits into from
Dec 16, 2015
Merged

#1260: Expose 'jobs/list' results #1279

merged 7 commits into from
Dec 16, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 9, 2015

Add a list_jobs() method to BigQuery client, returning instances of appropriate job classes.

See #1278 for issues related to the (hidden) job created by the synchronous query API.

Closes #1260.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Dec 9, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 9, 2015
dhermes
dhermes reviewed Dec 10, 2015
View reviewed changes
gcloud/bigquery/job.py
"""
name, config = cls._get_resource_config(resource)
dest_config = config['destinationTable']
assert dest_config['projectId'] == client.project

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Dec 10, 2015

Trying to review but having a hard time wrapping my head around the changes.

@tseaver
Copy link
Contributor Author

tseaver commented Dec 10, 2015

@dhermes the overall intent is to parse the individual jobs resources from the jobs/list response. The first four commits enable that parsing for each of the four "jobs" classes, while the fifth handles deciding which class to delegate to for each entry in the list.

@tseaver tseaver mentioned this pull request Dec 14, 2015
Closed
@tseaver
Add 'LoadTableFromStorageJob.from_api_repr' classmethod.
351248f 
Preparation for creating jobs from resources in future 'client.list_jobs'.
@tseaver
Add 'CopyJob.from_api_repr' classmethod.
9aef038 
Preparation for creating jobs from resources in future 'client.list_jobs'.
@tseaver
Add 'ExtractTableToStorageJob.from_api_repr' classmethod.
ab62ac7 
Preparation for creating jobs from resources in future 'client.list_jobs'.
@tseaver
Add 'RunAsyncQueryJob.from_api_repr' classmethod.
ad57744 
Preparation for creating jobs from resources in future 'client.list_jobs'.
@tseaver
Add 'Client.list_jobs'.
8c2cc6a 
Closes #1260.
@tseaver
Copy link
Contributor Author

tseaver commented Dec 14, 2015

Rebased to fix merge conflict.

dhermes
dhermes reviewed Dec 14, 2015
View reviewed changes
gcloud/bigquery/job.py
"""
name, config = cls._get_resource_config(resource)
dest_config = config['destinationTable']
assert dest_config['projectId'] == client.project

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor Author

tseaver commented Dec 15, 2015

@dhermes any remaining issues?

@dhermes
Copy link
Contributor

dhermes commented Dec 16, 2015

LGTM. (A bit uneasy about this. PR so big)

tseaver added a commit that referenced this pull request Dec 16, 2015
@tseaver
Merge pull request #1279 from tseaver/1260-expose_bq_jobs_list
a3c504f 
#1260: Expose 'jobs/list' results
@tseaver tseaver merged commit a3c504f into googleapis:master Dec 16, 2015
@tseaver tseaver deleted the 1260-expose_bq_jobs_list branch December 16, 2015 05:53
@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot