Add Support for Query Cursor & Order #126

lucemia · 2014-08-26T09:06:54Z

Add support for Google Cloud Datastore Query Cursor, and order by

add order by function

lucemia · 2014-08-27T07:03:23Z

I have signed an individual CLA. Should I send pull request via my personal branch?

gcloud/datastore/query.py

+    if end_cursor:
+      self._pb.end_cursor = base64.b64decode(end_cursor)
+
+  def order(self, *properties):


gcloud/datastore/helpers.py

@@ -60,7 +60,8 @@ def get_protobuf_attribute_and_value(val):
  return name + '_value', value


-def get_value_from_protobuf(pb):
+def get_value_from_value_pb(value_pb):
+  from entity import Entity


tseaver · 2014-09-29T19:55:37Z

We need test coverage, too. @silvolu, if these features are part of M1, then I'd volunteer to break them out into separate branches and add coverage.

lucemia · 2014-10-02T14:26:19Z

@tseaver
The pull request is from my master branch, I think that's why it included all my later update automatically
I will move 0475d5e and 9bd8642 to another PR.

silvolu · 2014-10-02T20:30:33Z

Fixed by #203 and #204.

tseaver · 2014-10-09T14:34:59Z

Note that the extra commits (for entity / blob / blob key support in protobuf values) are now relevant to #232 and #233.

- Adding test for branch miss in credentials._get_signed_query_params - Making storage.batch._unpack_batch_response work correctly in Python2 and Python3 (parser expects str in both) NOTE: Yet again %s caused issues between Py2 and Py3 (as in the PR googleapis#126 in oauth2client).

Reverse :type and :param to standard ordering.

decode the response json to MicroDict

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@6ed3a83 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3abfa0f1886adaf0b83f07cb117b24a639ea1cb9cffe56d43280b977033563eb Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…126)

* ci(python): run lint / unit tests / docs as GH actions Source-Link: googleapis/synthtool@57be0cd Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ed1f9983d5a935a89fe8085e8bb97d94e41015252c5b6c9771257cf8624367e6 * add a commit to activate gh actions Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

🤖 I have created a release \*beep\* \*boop\* --- ## [1.3.0](https://www.github.com/googleapis/python-bigquery-connection/compare/v1.2.3...v1.3.0) (2021-10-08) ### Features * add context manager support in client ([#125](https://www.github.com/googleapis/python-bigquery-connection/issues/125)) ([bf9cc26](https://www.github.com/googleapis/python-bigquery-connection/commit/bf9cc268363a2a6e115b6af65ab6b50c05bbde28)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [3.1.1](https://www.github.com/googleapis/python-bigquery-datatransfer/compare/v3.1.0...v3.1.1) (2021-04-07) ### Bug Fixes * require proto-plus>=1.15.0 ([91910f1](https://www.github.com/googleapis/python-bigquery-datatransfer/commit/91910f1ea01c5324fa63a7d85a034d08aeaae3f9)) * use correct retry deadline ([#121](https://www.github.com/googleapis/python-bigquery-datatransfer/issues/121)) ([91910f1](https://www.github.com/googleapis/python-bigquery-datatransfer/commit/91910f1ea01c5324fa63a7d85a034d08aeaae3f9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

@busunkim96

fix: disable always_use_jwt_access Committer: @busunkim96 PiperOrigin-RevId: 382142900 Source-Link: googleapis/googleapis@513440f Source-Link: googleapis/googleapis-gen@7b1e2c3

Source-Link: googleapis/synthtool@53ea389 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:e1793a23ae0ee9aafb2e3a53b564a351f74790dbe3c2d75f8fc3b8c43e5c036c

@busunkim96

Committer: @busunkim96 PiperOrigin-RevId: 382142900 Source-Link: googleapis/googleapis@513440f Source-Link: googleapis/googleapis-gen@7b1e2c3

) Source-Link: googleapis/synthtool@0c7b033 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:08e34975760f002746b1d8c86fdc90660be45945ee6d9db914d1508acdf9a547 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

fix(deps): require proto-plus >= 1.22.0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

#126) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [pre-commit/pre-commit-hooks](https://togithub.com/pre-commit/pre-commit-hooks) | repository | major | `v3.4.0` -> `v4.0.1` | --- ### Release Notes <details> <summary>pre-commit/pre-commit-hooks</summary> ### [`v4.0.1`](https://togithub.com/pre-commit/pre-commit-hooks/releases/v4.0.1) [Compare Source](https://togithub.com/pre-commit/pre-commit-hooks/compare/v4.0.0...v4.0.1) ##### Fixes - `check-shebang-scripts-are-executable` fix entry point. - [#602](https://togithub.com/pre-commit/pre-commit-hooks/issues/602) issue by [@Person-93](https://togithub.com/Person-93). - [#603](https://togithub.com/pre-commit/pre-commit-hooks/issues/603) PR by [@scop](https://togithub.com/scop). ### [`v4.0.0`](https://togithub.com/pre-commit/pre-commit-hooks/releases/v4.0.0) [Compare Source](https://togithub.com/pre-commit/pre-commit-hooks/compare/v3.4.0...v4.0.0) ##### Features - `check-json`: report duplicate keys. - [#558](https://togithub.com/pre-commit/pre-commit-hooks/issues/558) PR by [@AdityaKhursale](https://togithub.com/AdityaKhursale). - [#554](https://togithub.com/pre-commit/pre-commit-hooks/issues/554) issue by [@adamchainz](https://togithub.com/adamchainz). - `no-commit-to-branch`: add `main` to default blocked branches. - [#565](https://togithub.com/pre-commit/pre-commit-hooks/issues/565) PR by [@ndevenish](https://togithub.com/ndevenish). - `check-case-conflict`: check conflicts in directory names as well. - [#575](https://togithub.com/pre-commit/pre-commit-hooks/issues/575) PR by [@slsyy](https://togithub.com/slsyy). - [#70](https://togithub.com/pre-commit/pre-commit-hooks/issues/70) issue by [@andyjack](https://togithub.com/andyjack). - `check-vcs-permalinks`: forbid other branch names. - [#582](https://togithub.com/pre-commit/pre-commit-hooks/issues/582) PR by [@jack1142](https://togithub.com/jack1142). - [#581](https://togithub.com/pre-commit/pre-commit-hooks/issues/581) issue by [@jack1142](https://togithub.com/jack1142). - `check-shebang-scripts-are-executable`: new hook which ensures shebang'd scripts are executable. - [#545](https://togithub.com/pre-commit/pre-commit-hooks/issues/545) PR by [@scop](https://togithub.com/scop). ##### Fixes - `check-executables-have-shebangs`: Short circuit shebang lookup on windows. - [#544](https://togithub.com/pre-commit/pre-commit-hooks/issues/544) PR by [@scop](https://togithub.com/scop). - `requirements-txt-fixer`: Fix comments which have indentation - [#549](https://togithub.com/pre-commit/pre-commit-hooks/issues/549) PR by [@greshilov](https://togithub.com/greshilov). - [#548](https://togithub.com/pre-commit/pre-commit-hooks/issues/548) issue by [@greshilov](https://togithub.com/greshilov). - `pretty-format-json`: write to stdout using UTF-8 encoding. - [#571](https://togithub.com/pre-commit/pre-commit-hooks/issues/571) PR by [@jack1142](https://togithub.com/jack1142). - [#570](https://togithub.com/pre-commit/pre-commit-hooks/issues/570) issue by [@jack1142](https://togithub.com/jack1142). - Use more inclusive language. - [#599](https://togithub.com/pre-commit/pre-commit-hooks/issues/599) PR by [@asottile](https://togithub.com/asottile). ##### Breaking changes - Remove deprecated hooks: `flake8`, `pyflakes`, `autopep8-wrapper`. - [#597](https://togithub.com/pre-commit/pre-commit-hooks/issues/597) PR by [@asottile](https://togithub.com/asottile). </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻️ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/synthtool). Source-Link: googleapis/synthtool@333fd90 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:b8c131c558606d3cea6e18f8e87befbd448c1482319b0db3c5d5388fa6ea72e3

reverts previous commit for preventing normalization of versioning

* changes without context * build(python): update docfx job to use new plugin Source-Author: Dan Lee <71398022+dandhlee@users.noreply.github.com> Source-Date: Tue Mar 30 19:36:37 2021 -0400 Source-Repo: googleapis/synthtool Source-Sha: 4501974ad08b5d693311457e2ea4ce845676e329 Source-Link: googleapis/synthtool@4501974

Source-Link: googleapis/synthtool@53ea389 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:e1793a23ae0ee9aafb2e3a53b564a351f74790dbe3c2d75f8fc3b8c43e5c036c

* chore: update Java and Python dependencies PiperOrigin-RevId: 408420890 Source-Link: googleapis/googleapis@2921f9f Source-Link: googleapis/googleapis-gen@6598ca8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNjU5OGNhOGNiYmY1MjI2NzMzYTA5OWM0NTA2NTE4YTVhZjZmZjc0YyJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: Minor formatting chore: Update gapic-generator-python to v1.11.5 build: Update rules_python to 0.24.0 PiperOrigin-RevId: 563436317 Source-Link: googleapis/googleapis@42fd37b Source-Link: googleapis/googleapis-gen@280264c Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjgwMjY0Y2EwMmZiOTMxNmI0MjM3YTk2ZDBhZjFhMjM0M2E4MWE1NiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* docs: fix remaining broken links PiperOrigin-RevId: 443508623 Source-Link: googleapis/googleapis@fd6935f Source-Link: googleapis/googleapis-gen@4f659e3 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY2NTllM2I4YWNlMmU4NmMwMjdjNGZlY2E5ZGVjZDZlZTU4YzY0YyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: migrate to main branch * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

🤖 I have created a release \*beep\* \*boop\* --- ## [2.5.0](https://www.github.com/googleapis/python-oslogin/compare/v2.4.0...v2.5.0) (2021-10-14) ### Features * add support for python 3.10 ([#125](https://www.github.com/googleapis/python-oslogin/issues/125)) ([02163b7](https://www.github.com/googleapis/python-oslogin/commit/02163b7d7c8549145b90b3ddc830ce6bc3feaa63)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

lucemia and others added 6 commits August 26, 2014 16:03

add cursor support

25672e1

modify doc

7a001fd

add doc, change cursor type from bytes to base64

90ac07d

add order by function

5f796e6

fix bug

4a772c7

Merge pull request #1 from Tagtoo/feature-order

14019fc

add order by function

lucemia changed the title ~~Add Support for Query Cursor~~ Add Support for Query Cursor & Order Aug 27, 2014

lucemia added 2 commits September 17, 2014 12:13

add support for list_value, entity_value

0475d5e

add support entity

9bd8642

tseaver reviewed Sep 22, 2014
View reviewed changes

gcloud/datastore/query.py

if end_cursor:

self._pb.end_cursor = base64.b64decode(end_cursor)

def order(self, *properties):

This comment was marked as spam.

Sign in to view

tseaver added api: datastore Issues related to the Datastore API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Sep 22, 2014

tseaver reviewed Sep 29, 2014
View reviewed changes

gcloud/datastore/helpers.py

@@ -60,7 +60,8 @@ def get_protobuf_attribute_and_value(val):

return name + '_value', value

def get_value_from_protobuf(pb):

def get_value_from_value_pb(value_pb):

from entity import Entity

This comment was marked as spam.

Sign in to view

This was referenced Oct 1, 2014

Feature: datastore query order #203

Merged

Add cursor handling to datastore.query.Query. #204

Merged

silvolu closed this Oct 2, 2014

tseaver mentioned this pull request Oct 7, 2014

Support list values in entities #223

Closed

tseaver mentioned this pull request Oct 16, 2014

Fix #223: marshal list values from protobufs #246

Merged

dhermes pushed a commit to dhermes/google-cloud-python that referenced this pull request Jun 9, 2017

Merge pull request googleapis#126 from jgeewax/koss-doc-style

5ee7c15

Reverse :type and :param to standard ordering.

urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020

Merge pull request googleapis#126 from O365/bug_fixes

a2c8f3f

decode the response json to MicroDict

atulep pushed a commit that referenced this pull request Apr 3, 2023

chore: release 2.2.0 (#126)

8115e5d

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore: release 2.2.0 (#126)

71824c0

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 20, 2023

chore(deps): update dependency google-cloud-video-stitcher to v0.6.1 (#…

da9e1dd

…126)

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-storage to v1.37.1 (#126)

ff3aa07

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore: migrate default branch from master to main (#126)

6032911

parthea pushed a commit that referenced this pull request Sep 22, 2023

fix: disable always_use_jwt_access (#126)

7d58f2e

Committer: @busunkim96 PiperOrigin-RevId: 382142900 Source-Link: googleapis/googleapis@513440f Source-Link: googleapis/googleapis-gen@7b1e2c3

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency pytest to v6 (#126)

938d4cb

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-pubsub to v2.4.2 (#126)

1df10d5

parthea added a commit that referenced this pull request Oct 21, 2023

fix(deps): allow protobuf < 5.0.0 (#126)

4316a25

fix(deps): require proto-plus >= 1.22.0

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(main): release 1.4.1 (#126)

08647e3

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(revert): revert preventing normalization (#126)

e5164f9

reverts previous commit for preventing normalization of versioning

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency pillow to v8.2.0 (#126)

428b824

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(python): group renovate prs (#126)

60ab92c

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(python): disable dependency dashboard (#126)

658d854

parthea added a commit that referenced this pull request Oct 21, 2023

fix(deps): require google-api-core>=1.31.5, >=2.3.2 (#126)

60daf5a

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore: release 2.2.0 (#126)

9f2dab3

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

release-please bot mentioned this pull request Oct 30, 2023

chore: release main #11913

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Support for Query Cursor & Order #126

Add Support for Query Cursor & Order #126

lucemia commented Aug 26, 2014

lucemia commented Aug 27, 2014

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Sep 29, 2014

lucemia commented Oct 2, 2014

silvolu commented Oct 2, 2014

tseaver commented Oct 9, 2014

Add Support for Query Cursor & Order #126

Add Support for Query Cursor & Order #126

Conversation

lucemia commented Aug 26, 2014

lucemia commented Aug 27, 2014

This comment was marked as spam.

This comment was marked as spam.

tseaver commented Sep 29, 2014

lucemia commented Oct 2, 2014

silvolu commented Oct 2, 2014

tseaver commented Oct 9, 2014