Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Index.document' factory #1179

Merged
merged 2 commits into from
Oct 14, 2015
Merged

Add 'Index.document' factory #1179

merged 2 commits into from
Oct 14, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 14, 2015

No description provided.

@tseaver tseaver added the search label Oct 14, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2015
@dhermes
Copy link
Contributor

dhermes commented Oct 14, 2015

I'm reviewing under the assumption that this does not rely on #1178. LMK if I'm wrong.

@dhermes
Copy link
Contributor

dhermes commented Oct 14, 2015

LGTM

tseaver added a commit that referenced this pull request Oct 14, 2015
@tseaver
Merge pull request #1179 from tseaver/search-index_document_factory
60799e8 
Add 'Index.document' factory
@tseaver tseaver merged commit 60799e8 into googleapis:master Oct 14, 2015
@tseaver tseaver deleted the search-index_document_factory branch October 14, 2015 18:50
@tseaver
Copy link
Contributor Author

tseaver commented Oct 14, 2015

Your assumption was correct.

@tseaver tseaver mentioned this pull request Oct 14, 2015
Closed
@dhermes dhermes mentioned this pull request Jan 25, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @dhermes @googlebot