Skip to content

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 19, 2015

Uses #1068 as a base.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Aug 19, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Aug 19, 2015

@dhermes Rebased after merge of #1068. PTAL.

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Aug 19, 2015

  1. System test forthcoming?
  2. Similarly, have you compared our BigQuery system tests to those in gcloud-node (I keep forgetting to bring this up, sorry if it's out of place here)
  3. This all seems very vanilla / identical to existing. Is it worth have something more generic we can use (included generated tests for getters, setters and deleters, or just a generic subclass of property that we can test once)?
  4. How close to "done" with BigQuery? (Cut release at that point?)

@dhermes
Copy link
Contributor

dhermes commented Aug 19, 2015

Thanks for the tweaks. As for my other questions?

@tseaver
Copy link
Contributor Author

tseaver commented Aug 20, 2015

System test forthcoming?

Yes, shortly.

Similarly, have you compared our BigQuery system tests to those in gcloud-node (I keep forgetting to bring this up, sorry if it's out of place here).

I've looked at them: we have similar coverage, except one missing for #1068.

This all seems very vanilla / identical to existing. Is it worth have something more generic we can use (included generated tests for getters, setters and deleters, or just a generic subclass of property that we can test once)?

We could bag the property/validation stuff, and just rely on docs for the user-settable configuration attributes. Or we could write a 'validating descriptor' helper and use that instead of custom property methods.

How close to "done" with BigQuery? (Cut release at that point?)

We don't have coverage for the /upload APIs (multipart/resumable, just like storage). And we're missing Client.list_jobs. Other than that, I think we're close.

@tseaver
Copy link
Contributor Author

tseaver commented Aug 20, 2015

Rebased on top of #1075.

@dhermes
Copy link
Contributor

dhermes commented Aug 21, 2015

Ping me when #1075 is in.

@tseaver
Copy link
Contributor Author

tseaver commented Aug 23, 2015

@dhermes rebased after merge of #1075.

@dhermes
Copy link
Contributor

dhermes commented Aug 24, 2015

LGTM

tseaver added a commit that referenced this pull request Aug 24, 2015
@tseaver tseaver merged commit ddb26e2 into googleapis:master Aug 24, 2015
@tseaver tseaver deleted the bigquery-jobs_query branch August 24, 2015 20:03
gcf-owl-bot bot added a commit that referenced this pull request Jul 16, 2025
Source-Link: googleapis/googleapis@016414f

Source-Link: googleapis/googleapis-gen@259de81
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUtdjFiZXRhLy5Pd2xCb3QueWFtbCIsImgiOiIyNTlkZTgxM2UwNWU3NTJkNzkwOTI5NjZiNWY4MTY5NDViZmNkZGNhIn0=
ohmayr pushed a commit that referenced this pull request Jul 16, 2025
…to revision 20250708 (#1072) (#14109)

- [ ] Regenerate this pull request now.

Source-Link:
googleapis/googleapis@016414f

Source-Link:
googleapis/googleapis-gen@259de81
Copy-Tag:
eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUtdjFiZXRhLy5Pd2xCb3QueWFtbCIsImgiOiIyNTlkZTgxM2UwNWU3NTJkNzkwOTI5NjZiNWY4MTY5NDViZmNkZGNhIn0=

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@release-please release-please bot mentioned this pull request Jul 16, 2025
ohmayr pushed a commit that referenced this pull request Jul 17, 2025
🤖 I have created a release *beep* *boop*
---


<details><summary>google-cloud-compute: 1.33.0</summary>

##
[1.33.0](google-cloud-compute-v1.32.0...google-cloud-compute-v1.33.0)
(2025-07-16)


### Features

* [google-cloud-compute] Update Compute Engine v1 API to revision
20250708
([#1073](#1073))
([#14107](#14107))
([723ac5d](723ac5d))
</details>

<details><summary>google-cloud-compute-v1beta: 0.1.4</summary>

##
[0.1.4](google-cloud-compute-v1beta-v0.1.3...google-cloud-compute-v1beta-v0.1.4)
(2025-07-16)


### Features

* [google-cloud-compute-v1beta] Update Compute Engine v1beta API to
revision 20250708
([#1072](#1072))
([#14109](#14109))
([184c2f3](184c2f3))
</details>

<details><summary>google-cloud-container: 2.58.0</summary>

##
[2.58.0](google-cloud-container-v2.57.0...google-cloud-container-v2.58.0)
(2025-07-16)


### Features

* A new enum `Mode` is added
([f4d2243](f4d2243))
* A new enum `TransparentHugepageDefrag` is added
([f4d2243](f4d2243))
* A new enum `TransparentHugepageEnabled` is added
([f4d2243](f4d2243))
* A new field `additional_ip_ranges_configs` is added to message
`.google.container.v1.IPAllocationPolicy`
([f4d2243](f4d2243))
* A new field `auto_ipam_config` is added to message
`.google.container.v1.IPAllocationPolicy`
([f4d2243](f4d2243))
* A new field `boot_disk` is added to message
`.google.container.v1.NodeConfig`
([f4d2243](f4d2243))
* A new field `boot_disk` is added to message
`.google.container.v1.UpdateNodePoolRequest`
([f4d2243](f4d2243))
* A new field `default_compute_class_config` is added to message
`.google.container.v1.ClusterAutoscaling`
([f4d2243](f4d2243))
* A new field `desired_additional_ip_ranges_config` is added to message
`.google.container.v1.ClusterUpdate`
([f4d2243](f4d2243))
* A new field `desired_auto_ipam_config` is added to message
`.google.container.v1.ClusterUpdate`
([f4d2243](f4d2243))
* A new field `desired_user_managed_keys_config` is added to message
`.google.container.v1.ClusterUpdate`
([f4d2243](f4d2243))
* A new field `eviction_max_pod_grace_period_seconds` is added to
message `.google.container.v1.NodeKubeletConfig`
([f4d2243](f4d2243))
* A new field `eviction_minimum_reclaim` is added to message
`.google.container.v1.NodeKubeletConfig`
([f4d2243](f4d2243))
* A new field `eviction_soft_grace_period` is added to message
`.google.container.v1.NodeKubeletConfig`
([f4d2243](f4d2243))
* A new field `eviction_soft` is added to message
`.google.container.v1.NodeKubeletConfig`
([f4d2243](f4d2243))
* A new field `gke_auto_upgrade_config` is added to message
`.google.container.v1.Cluster`
([f4d2243](f4d2243))
* A new field `gke_auto_upgrade_config` is added to message
`.google.container.v1.ClusterUpdate`
([f4d2243](f4d2243))
* A new field `lustre_csi_driver_config` is added to message
`.google.container.v1.AddonsConfig`
([f4d2243](f4d2243))
* A new field `max_parallel_image_pulls` is added to message
`.google.container.v1.NodeKubeletConfig`
([f4d2243](f4d2243))
* A new field `min_node_cpus` is added to message
`.google.container.v1.SoleTenantConfig`
([f4d2243](f4d2243))
* A new field `mode` is added to message
`.google.container.v1.AnonymousAuthenticationConfig`
([f4d2243](f4d2243))
* A new field `single_process_oom_kill` is added to message
`.google.container.v1.NodeKubeletConfig`
([f4d2243](f4d2243))
* A new field `subnetwork` is added to message
`.google.container.v1.NodeNetworkConfig`
([f4d2243](f4d2243))
* A new field `transparent_hugepage_defrag` is added to message
`.google.container.v1.LinuxNodeConfig`
([f4d2243](f4d2243))
* A new field `transparent_hugepage_enabled` is added to message
`.google.container.v1.LinuxNodeConfig`
([f4d2243](f4d2243))
* A new message `AdditionalIPRangesConfig` is added
([f4d2243](f4d2243))
* A new message `AutoIpamConfig` is added
([f4d2243](f4d2243))
* A new message `BootDisk` is added
([f4d2243](f4d2243))
* A new message `DefaultComputeClassConfig` is added
([f4d2243](f4d2243))
* A new message `DesiredAdditionalIPRangesConfig` is added
([f4d2243](f4d2243))
* A new message `EvictionGracePeriod` is added
([f4d2243](f4d2243))
* A new message `EvictionMinimumReclaim` is added
([f4d2243](f4d2243))
* A new message `EvictionSignals` is added
([f4d2243](f4d2243))
* A new message `GkeAutoUpgradeConfig` is added
([f4d2243](f4d2243))
* A new message `LustreCsiDriverConfig` is added
([f4d2243](f4d2243))
* A new value `CLOUD_KMS_KEY_DESTROYED` is added to enum `Code`
([f4d2243](f4d2243))
</details>

<details><summary>google-cloud-geminidataanalytics: 0.2.0</summary>

##
[0.2.0](google-cloud-geminidataanalytics-v0.1.0...google-cloud-geminidataanalytics-v0.2.0)
(2025-07-16)


### ⚠ BREAKING CHANGES

* Correct the resource reference type for the parent field in
data_chat_service proto

### Features

* Add `setIAM` and `getIAM` methods for managing agent sharing
([b803c39](b803c39))


### Bug Fixes

* Correct the resource reference type for the parent field in
data_chat_service proto
([b803c39](b803c39))


### Documentation

* Update comments for multiple fields in Gemini Data Analytics API
([b803c39](b803c39))
</details>

<details><summary>google-cloud-licensemanager: 0.1.0</summary>

## 0.1.0 (2025-07-16)


### Features

* add initial files for google.cloud.licensemanager.v1
([#14087](#14087))
([aba2464](aba2464))
</details>

<details><summary>google-cloud-lustre: 0.1.2</summary>

##
[0.1.2](google-cloud-lustre-v0.1.1...google-cloud-lustre-v0.1.2)
(2025-07-16)


### Features

* add a new instance state UPDATING
([10d3aa9](10d3aa9))


### Documentation

* deprecate gke_support_enabled flag
([10d3aa9](10d3aa9))
</details>

<details><summary>google-cloud-run: 0.10.19</summary>

##
[0.10.19](google-cloud-run-v0.10.18...google-cloud-run-v0.10.19)
(2025-07-16)


### Features

* add new field `term_signal` to
`.google.cloud.run.v2.TaskAttemptResult`
([078e0e2](078e0e2))
* support GPU zonal redundancy setting for Cloud Run jobs
([078e0e2](078e0e2))
</details>

<details><summary>google-maps-addressvalidation: 0.3.20</summary>

##
[0.3.20](google-maps-addressvalidation-v0.3.19...google-maps-addressvalidation-v0.3.20)
(2025-07-16)


### Features

* add has_spell_corrected_components field to the Address Validation
verdict in the API response
([07eae34](07eae34))


### Documentation

* update proto field descriptions
([07eae34](07eae34))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants