Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing twine before deploying. #1061

Closed
wants to merge 1 commit into from

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 12, 2015

See travis-ci/dpl#299

Honestly dpl just needs to be fixed and I'd rather never submit this, but this is a fix if need be.

@dhermes dhermes added packaging do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 12, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Aug 12, 2015

See #1057 as well

@tseaver
Copy link
Contributor

tseaver commented Aug 13, 2015

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Aug 13, 2015

@tseaver I'm just going to leave this unmerged and hope the problem resolves itself before the next release. I'm subscribed to both travis-ci/dpl#296 and travis-ci/dpl#299 so hopefully I'll hear about a resolution soon.

@dhermes
Copy link
Contributor Author

dhermes commented Aug 19, 2015

With the closing of travis-ci/dpl#296 and travis-ci/dpl#299 it seems this fix is no longer needed.

@dhermes dhermes closed this Aug 19, 2015
@dhermes dhermes deleted the fix-twine-missing branch August 19, 2015 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants