Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes a non-deterministic failing test in bigquery. #1029

Merged
merged 1 commit into from
Aug 4, 2015
Merged

Fixes a non-deterministic failing test in bigquery. #1029

merged 1 commit into from
Aug 4, 2015

Commits on Jul 31, 2015

  1. Fixes a non-deterministic failing test in bigquery. 

    This has something to do with rounding of floats (and different
behavior between Python 2 and Python 3). For example, `.123` gets
"rounded down" when expressed as floating point:

>>> (0.123).hex()
'0x1.f7ced916872b0p-4'
>>> # Add 4 for exponent and multiply .123 by 1000
>>> 2**(52 + 4) * 123
8863084066665136128
>>> # Account for the factor of 1000 we've multiplied .123 by
>>> (0x1f7ced916872b0) * 1000
8863084066665136000
    @dhermes
    dhermes committed Jul 31, 2015
    Configuration menu
    Copy the full SHA
    742bd08 View commit details
    Browse the repository at this point in the history