Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery, Storage: Release patch versions of older releases to restrict range of 'google-resumable-media'. #9241

Closed
25 tasks done
crwilcox opened this issue Sep 17, 2019 · 4 comments
Assignees
Labels
api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.

Comments

@crwilcox
Copy link
Contributor

crwilcox commented Sep 17, 2019

Existing versions of google-cloud-storage and google-cloud-bigquery use an unrestricted version of google-resumable-media. In order to allow making incompatible changes we should create a version range, not just a minimum version. Do this back 1 year.
Specifier should be < 0.5.0dev

google-cloud-storage

  • 1.19.0 -> 1.19.1
  • 1.18.0 -> 1.18.1
  • 1.17.0 -> 1.17.1
  • 1.16.1 -> 1.16.2
  • 1.15.1 -> 1.15.2
  • 1.14.0 -> 1.14.1
  • 1.13.2 -> 1.13.3
  • 1.12.0 -> 1.12.1
  • 1.11.0 -> 1.11.1

google-cloud-bigquery

  • 1.20.0 -> 1.20.1 (IN PR BigQuery: Restrict version range of google-resumable-media. #9243)
  • 1.19.0 -> 1.19.1
  • 1.18.0 -> 1.18.1
  • 1.17.0 -> 1.17.1
  • 1.16.0 -> 1.16.1
  • 1.15.0 -> 1.15.1
  • 1.14.0 -> 1.14.1
  • 1.13.0 -> 1.13.1
  • 1.12.1 -> 1.12.2
  • 1.11.3 -> 1.11.4
  • 1.10.0 -> 1.10.1
  • 1.9.0 -> 1.9.1
  • 1.8.1 -> 1.8.2
  • 1.7.0 -> 1.7.2 (1.7.1 not properly released)
  • 1.6.1 -> 1.6.2
  • 1.5.1 -> 1.5.2
@crwilcox crwilcox self-assigned this Sep 17, 2019
@crwilcox
Copy link
Contributor Author

crwilcox commented Sep 17, 2019

Plan of Record

export VERSION=1.x.0
export NEW_VERSION=1.x.1

git checkout storage-${VERSION}
git checkout -b storage_${NEW_VERSION}
  1. update string in setup.py
sed -ie 's/\(google-resumable-media.*\)\"/\1, < 0.5.0dev\"/g' setup.py

sed -ie 's/version = \"'${VERSION}'\"/version = \"'${NEW_VERSION}'\"/g' setup.py
  1. update changelog
sed -ie 's/\#\# '${VERSION}'/## '${NEW_VERSION}'\
\
- Restrict version of `google-resumable-media` to be less than 0.5.0.\
\
## '${VERSION}'/g' CHANGELOG.md
  1. commit + tag
git commit -a -m "Restrict version range of google-resumable-media"
git tag -a storage-${NEW_VERSION} -m "Restrict version range of google-resumable-media"
  1. push tag
git push origin storage-${NEW_VERSION}
  1. release
python setup.py sdist bdist_wheel
twine upload --repository pypi dist/*

@crwilcox
Copy link
Contributor Author

Update, patched all GCS versions less than 1 year old.
BigQuery TODO

@crwilcox crwilcox added api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. labels Sep 17, 2019
@crwilcox
Copy link
Contributor Author

BigQuery (excepting current) complete.

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Sep 18, 2019
@tseaver tseaver added type: process A process-related concern. May include testing, release, or the like. and removed triage me I really want to be triaged. labels Sep 18, 2019
@tseaver tseaver changed the title Release patch versions of older releases to restrict range of google-resumable-media BigQuery, Storage: Release patch versions of older releases to restrict range of 'google-resumable-media'. Sep 18, 2019
@crwilcox
Copy link
Contributor Author

crwilcox commented Sep 19, 2019

It looks like we need to ship a bigquery 1.20.1 as well with a restricted range. @tseaver can we plan to do this with your test changes? (once this pr goes through #9243)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. api: storage Issues related to the Cloud Storage API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

No branches or pull requests

3 participants