Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: test_blob has many failures #9118

Closed
tritone opened this issue Aug 27, 2019 · 1 comment
Closed

Storage: test_blob has many failures #9118

tritone opened this issue Aug 27, 2019 · 1 comment
Assignees
Labels
api: storage Issues related to the Cloud Storage API. testing

Comments

@tritone
Copy link
Contributor

tritone commented Aug 27, 2019

I made a minor change to hmac_key.py and am seeing many seemingly unrelated test failures in tests/unit/test_blob.py . Example failure:

E   AssertionError: expected call not found.
E   Expected: request('GET', 'http://example.com/media/', data=None, headers={'accept-encoding': 'gzip'}, stream=True)
E   Actual: request('GET', 'http://example.com/media/', data=None, headers={'accept-encoding': 'gzip'}, stream=True, timeout=(61, 60))

Full failures are here: https://source.cloud.google.com/results/invocations/96b74148-63f7-4f77-8475-a539bbad1285/targets/cloud-devrel%2Fclient-libraries%2Fgoogle-cloud-python%2Fpresubmit%2Fstorage/log

After conferring with @frankyn I think this is caused by @crwilcox 's change in google-resumable-media-python: googleapis/google-resumable-media-python@ea95f0e . PR for this change is here: googleapis/google-resumable-media-python#88 .

The expected requests will have to be updated in many tests from test_blob in order to allow the test suite to pass again.

@tseaver
Copy link
Contributor

tseaver commented Aug 27, 2019

Via #9119.

@tseaver tseaver closed this as completed Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. testing
Projects
None yet
Development

No branches or pull requests

4 participants