Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pin for 'googleapis-common-protos'. #8686

Closed
31 tasks done
tseaver opened this issue Jul 16, 2019 · 3 comments
Closed
31 tasks done

Update pin for 'googleapis-common-protos'. #8686

tseaver opened this issue Jul 16, 2019 · 3 comments
Assignees
@tseaver
Labels
api: automl Issues related to the AutoML API. api: bigquery Issues related to the BigQuery API. api: bigquerystorage Issues related to the BigQuery Storage API. api: bigtable Issues related to the Bigtable API. api: clouderrorreporting Issues related to the Error Reporting API. api: cloudkms Issues related to the Cloud Key Management Service API. api: cloudresourcemanager Issues related to the Resource Manager API. api: core api: datacatalog Issues related to the Data Catalog API. api: datalabeling Issues related to the AI Platform Data Labeling Service API. api: dlp Issues related to the Sensitive Data Protection API. api: dns Issues related to the Cloud DNS API. api: firestore Issues related to the Firestore API. api: irm api: language Issues related to the Cloud Natural Language API API. api: logging Issues related to the Cloud Logging API. api: phishingprotection Issues related to the Phishing Protection API. api: redis Issues related to the Memorystore for Redis API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. api: spanner Issues related to the Spanner API. api: talent api: translation Issues related to the Cloud Translation API API. api: videointelligence Issues related to the Video Intelligence API API. packaging type: process A process-related concern. May include testing, release, or the like.

Comments

@tseaver
Copy link
Contributor

tseaver commented Jul 16, 2019 •
edited
Loading

From #8674.

Recent autogen changes have begun using features present only in googleapis-common-protos 1.6.0+, specifially the google.api.client package. E.g.:

$ git grep -l "google\/api\/client\.proto" | grep "\.proto$"
automl/google/cloud/automl_v1beta1/proto/prediction_service.proto
automl/google/cloud/automl_v1beta1/proto/service.proto
bigquery/google/cloud/bigquery_v2/proto/model.proto
bigquery_storage/google/cloud/bigquery_storage_v1beta1/proto/storage.proto
datacatalog/google/cloud/datacatalog_v1beta1/proto/datacatalog.proto
datalabeling/google/cloud/datalabeling_v1beta1/proto/data_labeling_service.proto
dlp/google/cloud/dlp_v2/proto/dlp.proto
irm/google/cloud/irm_v1alpha2/proto/incidents_service.proto
kms/google/cloud/kms_v1/proto/service.proto
language/google/cloud/language_v1/proto/language_service.proto
redis/google/cloud/redis_v1/proto/cloud_redis.proto
redis/google/cloud/redis_v1beta1/proto/cloud_redis.proto
talent/google/cloud/talent_v4beta1/proto/application_service.proto
talent/google/cloud/talent_v4beta1/proto/company_service.proto
talent/google/cloud/talent_v4beta1/proto/completion_service.proto
talent/google/cloud/talent_v4beta1/proto/event_service.proto
talent/google/cloud/talent_v4beta1/proto/job_service.proto
talent/google/cloud/talent_v4beta1/proto/profile_service.proto
talent/google/cloud/talent_v4beta1/proto/tenant_service.proto
translate/google/cloud/translate_v3beta1/proto/translation_service.proto
videointelligence/google/cloud/videointelligence_v1/proto/video_intelligence.proto

This "leakage" can break clients who are upgrading an existing virtualenv, because ce currently pin googleapis-common-protos >= 1.5.3, != 1.5.4, < 2.0dev in api_core/setup.py, and googleapis-common-protos >= 1.5.9, < 2.0.0dev in bigquery_storage/setup.py.

Steps to remediate:

Bump pins of google-cloud-core >= 1.0.3, < 2.0.0dev:

Release the world (as of 2019-10-10):

After merge of #9445:

After release of google-cloud-logging:
@tseaver tseaver added api: bigquery Issues related to the BigQuery API. packaging api: translation Issues related to the Cloud Translation API API. api: language Issues related to the Cloud Natural Language API API. api: videointelligence Issues related to the Video Intelligence API API. type: process A process-related concern. May include testing, release, or the like. api: dlp Issues related to the Sensitive Data Protection API. api: redis Issues related to the Memorystore for Redis API. api: automl Issues related to the AutoML API. api: cloudkms Issues related to the Cloud Key Management Service API. api: bigquerystorage Issues related to the BigQuery Storage API. api: irm api: talent api: datacatalog Issues related to the Data Catalog API. api: datalabeling Issues related to the AI Platform Data Labeling Service API. labels Jul 16, 2019
@tseaver tseaver self-assigned this Jul 16, 2019
@tseaver tseaver mentioned this issue Jul 16, 2019
Merged
tseaver added a commit that referenced this issue Jul 17, 2019
@tseaver
Update pins of 'googleapis-common-protos. (#8688)
29b3c4d 
Toward #8686.
This was referenced Jul 17, 2019
Merged
Merged
@tseaver
Copy link
Contributor Author

tseaver commented Jul 19, 2019

@busunkim96 Should we do a "release the world" dance, or is it sufficient that new releases will have the pin?

@busunkim96
Copy link
Contributor

@tseaver I'll have to do a "release the world" soonish to get client_options into the wild for the generated clients. Any things to watch out for when I make the release PRs?

@tseaver
Copy link
Contributor Author

tseaver commented Jul 19, 2019

@busunkim96 Maybe make them minor releases (rather than patch) due to the dependency bump? For the generated clients, you would be doing that anyway for a new feature.

@tseaver tseaver mentioned this issue Oct 10, 2019
Merged
@tseaver tseaver added api: bigtable Issues related to the Bigtable API. api: clouderrorreporting Issues related to the Error Reporting API. api: cloudresourcemanager Issues related to the Resource Manager API. api: dns Issues related to the Cloud DNS API. api: firestore Issues related to the Firestore API. labels Oct 10, 2019
@tseaver tseaver added api: logging Issues related to the Cloud Logging API. api: phishingprotection Issues related to the Phishing Protection API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. api: spanner Issues related to the Spanner API. labels Oct 10, 2019
@tseaver tseaver mentioned this issue Oct 15, 2019
Merged
@busunkim96 busunkim96 mentioned this issue Oct 16, 2019
Merged
@tseaver tseaver mentioned this issue Oct 22, 2019
Merged
@tseaver tseaver closed this as completed Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: automl Issues related to the AutoML API. api: bigquery Issues related to the BigQuery API. api: bigquerystorage Issues related to the BigQuery Storage API. api: bigtable Issues related to the Bigtable API. api: clouderrorreporting Issues related to the Error Reporting API. api: cloudkms Issues related to the Cloud Key Management Service API. api: cloudresourcemanager Issues related to the Resource Manager API. api: core api: datacatalog Issues related to the Data Catalog API. api: datalabeling Issues related to the AI Platform Data Labeling Service API. api: dlp Issues related to the Sensitive Data Protection API. api: dns Issues related to the Cloud DNS API. api: firestore Issues related to the Firestore API. api: irm api: language Issues related to the Cloud Natural Language API API. api: logging Issues related to the Cloud Logging API. api: phishingprotection Issues related to the Phishing Protection API. api: redis Issues related to the Memorystore for Redis API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. api: spanner Issues related to the Spanner API. api: talent api: translation Issues related to the Cloud Translation API API. api: videointelligence Issues related to the Video Intelligence API API. packaging type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tseaver @busunkim96