Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_PropertyMixin.reload should clear _changes #786

Closed
tseaver opened this issue Mar 31, 2015 · 1 comment · Fixed by #789
Closed

_PropertyMixin.reload should clear _changes #786

tseaver opened this issue Mar 31, 2015 · 1 comment · Fixed by #789
Assignees
@yoshi-automation
Labels
api: storage Issues related to the Cloud Storage API.
Milestone
Storage Future

Comments

@tseaver
Copy link
Contributor

tseaver commented Mar 31, 2015

No description provided.

@tseaver tseaver changed the title DISCUSSION: Should _PropertyMixin.reload clear _changes? _PropertyMixin.reload should clear _changes Mar 31, 2015
@tseaver
Copy link
Contributor Author

tseaver commented Mar 31, 2015

Because _changes is only a set of changed keys (rather than a COW dict of changed values).

@dhermes dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 31, 2015
@dhermes dhermes modified the milestone: Storage Future Mar 31, 2015
@dhermes dhermes self-assigned this Mar 31, 2015
dhermes added a commit to dhermes/google-cloud-python that referenced this issue Mar 31, 2015
@dhermes
Making _PropertyMixin.patch() and reload() reset the changes.
f92e9fe 
Fixes googleapis#786.
@dhermes dhermes mentioned this issue Mar 31, 2015
Merged
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
feat: Update Compute Engine API to revision 20230307 (#786) (#403)
e84d22d 
* feat: Update Compute Engine API to revision 20230307 (#786)

Source-Link: googleapis/googleapis@f64a3c8

Source-Link: googleapis/googleapis-gen@808541b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODA4NTQxYjdlNzY5N2UyOTg0YTBlYTBlYmExYWRiNTU2MGRhZGU5NyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@ryanmats @busunkim96
random generation of keyring / cryptokey names [(#786)](GoogleCloudPl…
468bab0 
…atform/python-docs-samples#786)

* random generation of keyring / cryptokey names

* Fixed formatting of keyring name and cryptokey name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
Storage Future
Development

Successfully merging a pull request may close this issue.

Making _PropertyMixin.patch() and reload() reset the changes. dhermes/google-cloud-python
3 participants
@tseaver @dhermes @yoshi-automation