Update Key API to be more user-friendly per design doc discussion #451

dhermes · 2014-12-19T20:21:08Z

Related ~~to #3 and~~
https://docs.google.com/document/d/1xKw8Tz6lfN5uOcv0my4uUgFSeDoRzwCLho2UGlBpqDU/edit

Plan to make this work:

The text was updated successfully, but these errors were encountered:

Addresses first part of googleapis#451. Also removes uses of path in place of key since Key constructor will enable such easy use going forward.

Addresses second part of googleapis#451. In some cases, since no valid replacements for setters are implemented here, the functionality is replaced with hacks using protected methods. Also added a getter for Key._dataset_id and made the Key.path property return a copy since a `list` of `dict`s is very much mutable.

This is in preparation for adding parent to the constructor. Addresses third part of googleapis#451.

Addresses fourth part of googleapis#451.

Addresses fifth part of googleapis#451.

dhermes · 2014-12-23T03:45:09Z

UPDATE: Not necessary since Key.compare_to_proto was removed.

We should probably also move

        for element in protobuf.path_element:
            key_part = {}
            for descriptor, value in element._fields.items():
                key_part[descriptor.name] = value
            path.append(key_part)

(repeated in Key.compare_to_proto, helpers.key_from_protobuf and test_entity._Key.compare_to_proto) into it's own method.

Addresses sixth part of googleapis#451.

Addresses seventh part of googleapis#451. Also requires removing the dataset_id from generated protobufs due to googleapis/google-cloud-datastore#59. This occurs also in __key__ filters and ancestor queries.

Addresses first part of googleapis#451. Also removes uses of path in place of key since Key constructor will enable such easy use going forward.

Addresses second part of googleapis#451. In some cases, since no valid replacements for setters are implemented here, the functionality is replaced with hacks using protected methods. Also added a getter for Key._dataset_id and made the Key.path property return a copy since a `list` of `dict`s is very much mutable.

This is in preparation for adding parent to the constructor. Addresses third part of googleapis#451.

Addresses fourth part of googleapis#451.

Addresses fifth part of googleapis#451.

Addresses sixth part of googleapis#451.

Addresses seventh part of googleapis#451. Also requires removing the dataset_id from generated protobufs due to googleapis/google-cloud-datastore#59. This occurs also in __key__ filters and ancestor queries.

Addresses eighth part of googleapis#451.

Addresses fourth part of googleapis#451.

Addresses fifth part of googleapis#451.

Addresses sixth part of googleapis#451.

Addresses seventh part of googleapis#451. Also requires removing the dataset_id from generated protobufs due to googleapis/google-cloud-datastore#59. This occurs also in __key__ filters and ancestor queries.

Addresses sixth part of googleapis#451.

Addresses seventh part of googleapis#451. Also requires removing the dataset_id from generated protobufs due to googleapis/google-cloud-datastore#59. This occurs also in __key__ filters and ancestor queries.

Addresses eighth part of googleapis#451.

dhermes · 2015-01-03T01:07:50Z

Putting off bulk doc fixes until API is stable again

Co-authored-by: Nitsan Shai <nshai@google.com> Co-authored-by: nicain <nicain.seattle@gmail.com>

PiperOrigin-RevId: 504600937 Source-Link: googleapis/googleapis@91bee51 Source-Link: googleapis/googleapis-gen@70424b9 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzA0MjRiOTQ1N2QxNWVkODUyYTBhMGI5YTRmMDMyZjJiMzA5YjMyYyJ9 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@56da63e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7

* docs: removes deprecated sample * modifies tags to matched deprecated function call

* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

* fix(deps): allow protobuf 3.19.5 * explicitly exclude protobuf 4.21.0

Co-authored-by: Nitsan Shai <nshai@google.com> Co-authored-by: nicain <nicain.seattle@gmail.com>

dhermes added the api: datastore Issues related to the Datastore API. label Dec 19, 2014

dhermes self-assigned this Dec 19, 2014

This was referenced Dec 21, 2014

Fix 3 and 451 #454

Closed

Should datastore Key's be immutable? #3

Closed

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 22, 2014

Remove Key.from_path and derivative uses.

f645323

Addresses first part of googleapis#451. Also removes uses of path in place of key since Key constructor will enable such easy use going forward.

dhermes mentioned this issue Dec 22, 2014

Address first part of 451: Remove Key.from_path #456

Merged

dhermes changed the title ~~Change Key constructor to accept paths as args~~ Update Key API to be more user-friendly per design doc discussion Dec 23, 2014

dhermes mentioned this issue Dec 23, 2014

Address second part of 451: Remove all setters and make attrs into @property #458

Merged

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 23, 2014

Making Key.parent return the same instance on return calls.

f4d569c

This is in preparation for adding parent to the constructor. Addresses third part of googleapis#451.

dhermes mentioned this issue Dec 23, 2014

Address third part of 451: Storing Key.parent on instance for future calls #459

Merged

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 23, 2014

Make Key constructor easier to use by taking positional args.

c17800d

Addresses fourth part of googleapis#451.

dhermes mentioned this issue Dec 23, 2014

Address fourth part of 451: Make Key constructor easier to use by taking positional args. #460

Merged

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 23, 2014

Implement Key.complete_key for auto_id on partial keys.

64ab5ee

Addresses fifth part of googleapis#451.

dhermes mentioned this issue Dec 23, 2014

Address fifth part of 451: Implement Key.complete_key for auto_id on partial keys. #461

Merged

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 23, 2014

Implement Key.compare_to_proto to check pb keys against existing.

031b864

Addresses sixth part of googleapis#451.

dhermes mentioned this issue Dec 23, 2014

Address sixth part of 451: Implement Key.compare_to_proto to check pb keys against existing. #462

Merged

dhermes mentioned this issue Dec 23, 2014

Address seventh part of 451: Make dataset_id required on Key. #463

Merged

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 23, 2014

Remove Key.from_path and derivative uses.

3c394bb

Addresses first part of googleapis#451. Also removes uses of path in place of key since Key constructor will enable such easy use going forward.

dhermes mentioned this issue Dec 24, 2014

no working equality method for entities #465

Closed

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 30, 2014

Remove Key.from_path and derivative uses.

bd71dc6

Addresses first part of googleapis#451. Also removes uses of path in place of key since Key constructor will enable such easy use going forward.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 30, 2014

Making Key.parent return the same instance on return calls.

9aff877

This is in preparation for adding parent to the constructor. Addresses third part of googleapis#451.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 30, 2014

Make Key constructor easier to use by taking positional args.

03f5dd8

Addresses fourth part of googleapis#451.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 30, 2014

Implement Key.complete_key for auto_id on partial keys.

1442143

Addresses fifth part of googleapis#451.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 30, 2014

Implement Key.compare_to_proto to check pb keys against existing.

1778430

Addresses sixth part of googleapis#451.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 30, 2014

Adding parent to Key constructor.

aa5adc2

Addresses eighth part of googleapis#451.

dhermes mentioned this issue Dec 30, 2014

Address eighth part of 451: Add parent to constructor #476

Merged

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 31, 2014

Make Key constructor easier to use by taking positional args.

c616671

Addresses fourth part of googleapis#451.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 31, 2014

Implement Key.complete_key for auto_id on partial keys.

33d546d

Addresses fifth part of googleapis#451.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 31, 2014

Implement Key.compare_to_proto to check pb keys against existing.

cc59310

Addresses sixth part of googleapis#451.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 31, 2014

Implement Key.compare_to_proto to check pb keys against existing.

aaf33d3

Addresses sixth part of googleapis#451.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 31, 2014

Implement Key.compare_to_proto to check pb keys against existing.

fb67144

Addresses sixth part of googleapis#451.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 31, 2014

Adding parent to Key constructor.

07b4cfb

Addresses eighth part of googleapis#451.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Dec 31, 2014

Adding parent to Key constructor.

8486080

Addresses eighth part of googleapis#451.

dhermes mentioned this issue Jan 3, 2015

Remove dataset from Entity constructor and allow a key #484

Closed

dhermes closed this as completed Jan 3, 2015

dhermes mentioned this issue Jan 3, 2015

Creating a new datastore.entity with a key name is a pain #82

Closed

dhermes mentioned this issue Jan 12, 2015

Detecting GCE sometimes takes forever. googleapis/oauth2client#93

Closed

jgeewax modified the milestone: Datastore Stable Jan 30, 2015

yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 7, 2020

atulep pushed a commit that referenced this issue Apr 6, 2023

docs(samples): add quickstart code sample for STT V2 (#451)

c253e53

Co-authored-by: Nitsan Shai <nshai@google.com> Co-authored-by: nicain <nicain.seattle@gmail.com>

atulep pushed a commit that referenced this issue Apr 6, 2023

docs(samples): add quickstart code sample for STT V2 (#451)

a6dbff0

Co-authored-by: Nitsan Shai <nshai@google.com> Co-authored-by: nicain <nicain.seattle@gmail.com>

atulep pushed a commit that referenced this issue Apr 18, 2023

docs(samples): add quickstart code sample for STT V2 (#451)

b35d8f3

Co-authored-by: Nitsan Shai <nshai@google.com> Co-authored-by: nicain <nicain.seattle@gmail.com>

parthea pushed a commit that referenced this issue Sep 22, 2023

docs: removes deprecated sample (#451)

1284e3d

* docs: removes deprecated sample * modifies tags to matched deprecated function call

parthea added a commit that referenced this issue Sep 22, 2023

fix(deps): allow protobuf 3.19.5 (#451)

86edfbb

* fix(deps): allow protobuf 3.19.5 * explicitly exclude protobuf 4.21.0

parthea pushed a commit that referenced this issue Oct 22, 2023

docs(samples): add quickstart code sample for STT V2 (#451)

87fd86e

Co-authored-by: Nitsan Shai <nshai@google.com> Co-authored-by: nicain <nicain.seattle@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Key API to be more user-friendly per design doc discussion #451

Update Key API to be more user-friendly per design doc discussion #451

dhermes commented Dec 19, 2014

dhermes commented Dec 23, 2014

dhermes commented Jan 3, 2015

Update Key API to be more user-friendly per design doc discussion #451

Update Key API to be more user-friendly per design doc discussion #451

Comments

dhermes commented Dec 19, 2014

dhermes commented Dec 23, 2014

dhermes commented Jan 3, 2015