Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstrings from fetch_data method needs to be updated #3576

Closed
WillFuks opened this issue Jul 4, 2017 · 2 comments
Closed

Docstrings from fetch_data method needs to be updated #3576

WillFuks opened this issue Jul 4, 2017 · 2 comments
Assignees
Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@WillFuks
Copy link

WillFuks commented Jul 4, 2017

Hello,

Recently a question was posted in SO asking about the return params of the fetch_data method of `QueryResults' in BigQuery client.

As it seems, the return is no longer a tuple with 3 values but rather an object of the class HTTPIterator. Looks like the docstrings needs to be updated (if it could describe some quick example of how to use the iterator it'd be quite helpful :)!)

Thanks,

@lukesneeringer
Copy link
Contributor

Hi @WillFuks,
Thank you for reporting this. We will get that updated.

@lukesneeringer lukesneeringer added docs priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 5, 2017
@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Jul 5, 2017
@ryan-schroeder
Copy link

ryan-schroeder commented Jul 7, 2017

Thanks! I was about to post a question regarding this as well, cheers! =) Thanks for all your work on this.
(Edit, the docs still show the old return value; do these docs generate from the docstrings? https://googlecloudplatform.github.io/google-cloud-python/stable/bigquery-query.html#google.cloud.bigquery.query.QueryResults.fetch_data)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

4 participants