-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error reporting instrumentation and SIGTERM handling #2819
Comments
@waprin thoughts? |
yes @karan has already asked for it, I said I would plan to get it done this quarter, I still have a month left!! Was going to start this week, already did some preliminary research, but need to do a bit more to totally understand what we want and what we can get. |
Thanks Bill. Just creating this as an external tracker! Let me know what I can do to help. Really excited for this work. |
@waprin I think we have this now, correct? (If so, let me know so I can close this; if not, what is the priority on it?) |
Yes, I will still need to add some memory stats but that will also be a small change. |
I think priority is probably P2 or P3 hence the chipping away in free cycles but it's close to done, will close after. |
Can we just use the standard I worked a lot on the C++ crash handling inside Google, and it's tremendously difficult to get everything right in a robust and portable way. And there is a direct correlation where the more elaborate you make the crash handler, the less reliable it is. Writing to files other than stdout/stderr is iffy, let alone making RPC calls. |
Hello, As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates. My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request. Thank you! |
Dependent on #1921, we need to add a SIGTERM handler that can publish thread trace and heap info to Error Reporting.
Example interface:
The text was updated successfully, but these errors were encountered: