Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error reporting instrumentation and SIGTERM handling #2819

Closed
karan opened this issue Dec 6, 2016 · 8 comments
Closed

Error reporting instrumentation and SIGTERM handling #2819

karan opened this issue Dec 6, 2016 · 8 comments
Assignees
Labels
api: clouderrorreporting Issues related to the Error Reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release.

Comments

@karan
Copy link

karan commented Dec 6, 2016

Dependent on #1921, we need to add a SIGTERM handler that can publish thread trace and heap info to Error Reporting.

Example interface:

from google.cloud import error_reporting
client = error_reporting.Client(project='my-project',
                                               credentials=creds,
                                               shutdownLogs={threadDump: True, heapInfo: False})
@dhermes
Copy link
Contributor

dhermes commented Dec 6, 2016

@waprin thoughts?

@waprin
Copy link
Contributor

waprin commented Dec 6, 2016

yes @karan has already asked for it, I said I would plan to get it done this quarter, I still have a month left!! Was going to start this week, already did some preliminary research, but need to do a bit more to totally understand what we want and what we can get.

@karan
Copy link
Author

karan commented Dec 6, 2016

Thanks Bill. Just creating this as an external tracker! Let me know what I can do to help. Really excited for this work.

@dhermes dhermes added api: clouderrorreporting Issues related to the Error Reporting API. and removed api: clouderrorreporting Issues related to the Error Reporting API. error reporting labels Feb 23, 2017
@lukesneeringer
Copy link
Contributor

@waprin I think we have this now, correct? (If so, let me know so I can close this; if not, what is the priority on it?)

@danoscarmike danoscarmike added priority: p2 Moderately-important priority. Fix may not be included in next release. Status: Acknowledged labels Feb 28, 2017
@waprin
Copy link
Contributor

waprin commented Feb 28, 2017

Yes, I will still need to add some memory stats but that will also be a small change.

@waprin
Copy link
Contributor

waprin commented Feb 28, 2017

I think priority is probably P2 or P3 hence the chipping away in free cycles but it's close to done, will close after.

@duggelz
Copy link

duggelz commented Mar 30, 2017

Can we just use the standard faulthandler module from Python 3 (and backported to Python 2 on PyPI)?

I worked a lot on the C++ crash handling inside Google, and it's tremendously difficult to get everything right in a robust and portable way. And there is a direct correlation where the more elaborate you make the crash handler, the less reliable it is. Writing to files other than stdout/stderr is iffy, let alone making RPC calls.

@lukesneeringer
Copy link
Contributor

Hello,
One of the challenges of maintaining a large open source project is that sometimes, you can bite off more than you can chew. As the lead maintainer of google-cloud-python, I can definitely say that I have let the issues here pile up.

As part of trying to get things under control (as well as to empower us to provide better customer service in the future), I am declaring a "bankruptcy" of sorts on many of the old issues, especially those likely to have been addressed or made obsolete by more recent updates.

My goal is to close stale issues whose relevance or solution is no longer immediately evident, and which appear to be of lower importance. I believe in good faith that this is one of those issues, but I am scanning quickly and may occasionally be wrong. If this is an issue of high importance, please comment here and we will reconsider. If this is an issue whose solution is trivial, please consider providing a pull request.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: clouderrorreporting Issues related to the Error Reporting API. priority: p2 Moderately-important priority. Fix may not be included in next release.
Projects
None yet
Development

No branches or pull requests

6 participants