Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset exists (409) / dataset still in use (DELETE --> 400) #2318

Closed
dhermes opened this issue Sep 15, 2016 · 7 comments
Closed

Dataset exists (409) / dataset still in use (DELETE --> 400) #2318

dhermes opened this issue Sep 15, 2016 · 7 comments
Assignees
Labels
api: bigquery Issues related to the BigQuery API.

Comments

@dhermes
Copy link
Contributor

dhermes commented Sep 15, 2016

python2:

  • Still in use: precise-truck-742:system_tests_160041019_1473898532
  • Exists: precise-truck-742:system_tests_160041019_1473898532

then python3:

  • Still in use: precise-truck-742:system_tests_160041019_1473898730
  • Exists: precise-truck-742:system_tests_160041019_1473898730

From https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/160041019

Two proposed fixes:

  • Make sure the 400 is caught and retried for "still in use"
  • Use dataset IDs unique to each test (if possible)
@dhermes dhermes added api: bigquery Issues related to the BigQuery API. flaky labels Sep 15, 2016
@tseaver
Copy link
Contributor

tseaver commented Sep 15, 2016

Big 👍 for avoiding shared dataset IDs.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 16, 2016

@tseaver It's unclear if #2323 (double Michael Jordan) actually will fix the 400 "still in use". But it's not worth leaving this open forever.

@tseaver
Copy link
Contributor

tseaver commented Sep 16, 2016

Because testcases no longer share dataset names, there isn't going to be a case where the eventual-consistency window for one testcase deleting its dataset overlaps the creation during setup of another testcase.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 16, 2016

But the clean-up of each dataset will be a delete and the "still in use" on DELETE is where the issue came from.

@tseaver tseaver reopened this Sep 16, 2016
@dhermes
Copy link
Contributor Author

dhermes commented Sep 16, 2016

@tseaver Let's leave it closed until the "still in use" shows up again in the wild?

@tseaver
Copy link
Contributor

tseaver commented Sep 16, 2016

Hmm, I just kicked in #2333 to address it.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 16, 2016

Oh gotcha. SGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Development

No branches or pull requests

2 participants