Skip to content

Commit

Permalink
BQ: remove redundant __eq__ from Query Parameters. (#4055)
Browse files Browse the repository at this point in the history
Got duplicate definitions after the rebase.
  • Loading branch information
tswast committed Oct 16, 2017
1 parent 83319e1 commit ed8b2fe
Showing 1 changed file with 0 additions and 24 deletions.
24 changes: 0 additions & 24 deletions bigquery/google/cloud/bigquery/_helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -527,14 +527,6 @@ def __init__(self, name, type_, value):
self.type_ = type_
self.value = value

def __eq__(self, other):
if not isinstance(other, ScalarQueryParameter):
return NotImplemented
return(
self.name == other.name and
self.type_ == other.type_ and
self.value == other.value)

@classmethod
def positional(cls, type_, value):
"""Factory for positional paramater.
Expand Down Expand Up @@ -637,14 +629,6 @@ def __init__(self, name, array_type, values):
self.array_type = array_type
self.values = values

def __eq__(self, other):
if not isinstance(other, ArrayQueryParameter):
return NotImplemented
return(
self.name == other.name and
self.array_type == other.array_type and
self.values == other.values)

@classmethod
def positional(cls, array_type, values):
"""Factory for positional parameters.
Expand Down Expand Up @@ -789,14 +773,6 @@ def __init__(self, name, *sub_params):
types[sub.name] = sub.type_
values[sub.name] = sub.value

def __eq__(self, other):
if not isinstance(other, StructQueryParameter):
return NotImplemented
return(
self.name == other.name and
self.struct_types == other.struct_types and
self.struct_values == other.struct_values)

@classmethod
def positional(cls, *sub_params):
"""Factory for positional parameters.
Expand Down

0 comments on commit ed8b2fe

Please sign in to comment.