Merge pull request #873 from tseaver/825-storage-remove_blob_connection

Remove 'Blob.connection' property.
googleapis · May 13, 2015 · d74e8f2 · d74e8f2
2 parents 290b09e + e1f1db1
commit d74e8f2
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 14 deletions.
diff --git a/gcloud/storage/blob.py b/gcloud/storage/blob.py
@@ -132,16 +132,6 @@ def __repr__(self):
 
         return '<Blob: %s, %s>' % (bucket_name, self.name)
 
-    @property
-    def connection(self):
-        """Getter property for the connection to use with this Blob.
-
-        :rtype: :class:`gcloud.storage.connection.Connection` or None
-        :returns: The connection to use, or None if no connection is set.
-        """
-        if self.bucket and self.bucket.connection:
-            return self.bucket.connection
-
     @property
     def path(self):
         """Getter property for the URL path to this Blob.

diff --git a/gcloud/storage/test_blob.py b/gcloud/storage/test_blob.py
@@ -40,7 +40,6 @@ def mock_get_bucket():
             blob = self._makeOne(None)
 
         self.assertEqual(blob.bucket, FAKE_BUCKET)
-        self.assertEqual(blob.connection, None)
         self.assertEqual(blob.name, None)
         self.assertEqual(blob._properties, {})
         self.assertFalse(blob._acl.loaded)
@@ -50,7 +49,6 @@ def test_ctor_defaults(self):
         FAKE_BUCKET = _Bucket(None)
         blob = self._makeOne(None, bucket=FAKE_BUCKET)
         self.assertEqual(blob.bucket, FAKE_BUCKET)
-        self.assertEqual(blob.connection, None)
         self.assertEqual(blob.name, None)
         self.assertEqual(blob._properties, {})
         self.assertFalse(blob._acl.loaded)
@@ -63,7 +61,6 @@ def test_ctor_explicit(self):
         properties = {'key': 'value'}
         blob = self._makeOne(BLOB_NAME, bucket=bucket, properties=properties)
         self.assertTrue(blob.bucket is bucket)
-        self.assertTrue(blob.connection is connection)
         self.assertEqual(blob.name, BLOB_NAME)
         self.assertEqual(blob._properties, properties)
         self.assertFalse(blob._acl.loaded)

diff --git a/gcloud/storage/test_bucket.py b/gcloud/storage/test_bucket.py
@@ -73,7 +73,6 @@ def test_get_items_from_response_non_empty(self):
         self.assertEqual(len(blobs), 1)
         blob = blobs[0]
         self.assertTrue(isinstance(blob, Blob))
-        self.assertTrue(blob.connection is connection)
         self.assertEqual(blob.name, BLOB_NAME)
         self.assertEqual(iterator.prefixes, ('foo',))