Skip to content

Commit d65e970

Browse files
dhermeslukesneeringer
authored andcommitted
Cut release 1.0.0 of logging package. (#3278)
1 parent 8eb951d commit d65e970

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

packages/google-cloud-logging/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858

5959
setup(
6060
name='google-cloud-logging',
61-
version='0.24.0',
61+
version='1.0.0',
6262
description='Python Client for Stackdriver Logging',
6363
long_description=README,
6464
namespace_packages=[

packages/google-cloud-logging/tests/unit/test__gax.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1151,11 +1151,12 @@ def test_unregistered_type(self):
11511151

11521152
entry_pb = LogEntry(proto_payload=any_pb, timestamp=timestamp)
11531153
result = self._call_fut(entry_pb)
1154-
expected = {
1155-
'protoPayload': any_pb,
1156-
'timestamp': '1970-01-01T00:01:01.001234Z',
1157-
}
1158-
self.assertEqual(result, expected)
1154+
self.assertEqual(len(result), 2)
1155+
self.assertEqual(result['timestamp'], '1970-01-01T00:01:01.001234Z')
1156+
# NOTE: This "hack" is needed on Windows, where the equality check
1157+
# for an ``Any`` instance fails on unregistered types.
1158+
self.assertEqual(result['protoPayload'].type_url, type_url)
1159+
self.assertEqual(result['protoPayload'].value, metadata_bytes)
11591160

11601161
def test_registered_type(self):
11611162
from google.cloud.proto.logging.v2.log_entry_pb2 import LogEntry

0 commit comments

Comments
 (0)