Skip to content

Commit cefff49

Browse files
committed
Merge pull request #1716 from tseaver/1703-fix_coverage_gap
Fix coverage gap introduced in PR #1703.
2 parents 465976a + a6cce3f commit cefff49

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

gcloud/bigquery/table.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -422,6 +422,8 @@ def _build_resource(self):
422422
resource['schema'] = {
423423
'fields': _build_schema_resource(self._schema)
424424
}
425+
else:
426+
raise ValueError("Set either 'view_query' or 'schema'.")
425427

426428
return resource
427429

gcloud/bigquery/test_table.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,15 @@ def test_from_api_repr_w_properties(self):
437437
self.assertTrue(table._dataset._client is client)
438438
self._verifyResourceProperties(table, RESOURCE)
439439

440+
def test_create_no_view_query_no_schema(self):
441+
conn = _Connection()
442+
client = _Client(project=self.PROJECT, connection=conn)
443+
dataset = _Dataset(client)
444+
table = self._makeOne(self.TABLE_NAME, dataset)
445+
446+
with self.assertRaises(ValueError):
447+
table.create()
448+
440449
def test_create_w_bound_client(self):
441450
from gcloud.bigquery.table import SchemaField
442451
PATH = 'projects/%s/datasets/%s/tables' % (self.PROJECT, self.DS_NAME)

0 commit comments

Comments
 (0)