Skip to content

Commit ca14aec

Browse files
committed
Return instance instead of list for ImagePropertiesAnnotation.
1 parent 1bcd5dd commit ca14aec

4 files changed

Lines changed: 6 additions & 14 deletions

File tree

‎system_tests/vision.py‎

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -497,9 +497,7 @@ def test_detect_properties_content(self):
497497
with open(FACE_FILE, 'rb') as image_file:
498498
image = client.image(content=image_file.read())
499499
properties = image.detect_properties()
500-
self.assertEqual(len(properties), 1)
501-
image_property = properties[0]
502-
self._assert_properties(image_property)
500+
self._assert_properties(properties[0])
503501

504502
def test_detect_properties_gcs(self):
505503
client = Config.CLIENT
@@ -514,14 +512,10 @@ def test_detect_properties_gcs(self):
514512

515513
image = client.image(source_uri=source_uri)
516514
properties = image.detect_properties()
517-
self.assertEqual(len(properties), 1)
518-
image_property = properties[0]
519-
self._assert_properties(image_property)
515+
self._assert_properties(properties[0])
520516

521517
def test_detect_properties_filename(self):
522518
client = Config.CLIENT
523519
image = client.image(filename=FACE_FILE)
524520
properties = image.detect_properties()
525-
self.assertEqual(len(properties), 1)
526-
image_property = properties[0]
527-
self._assert_properties(image_property)
521+
self._assert_properties(properties[0])

‎vision/google/cloud/vision/annotations.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ def _make_image_properties_from_pb(image_properties):
166166
:rtype: list
167167
:returns: List of ``ImageProperties``.
168168
"""
169-
return ImagePropertiesAnnotation.from_pb(image_properties)
169+
return [ImagePropertiesAnnotation.from_pb(image_properties)]
170170

171171

172172
def _entity_from_response_type(feature_type, results):

‎vision/google/cloud/vision/color.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ def from_pb(cls, image_properties):
5656
"""
5757
colors = getattr(image_properties.dominant_colors, 'colors', ())
5858
if len(colors) > 0:
59-
return [cls([ColorInformation.from_pb(color) for color in colors])]
59+
return cls([ColorInformation.from_pb(color) for color in colors])
6060

6161
@property
6262
def colors(self):

‎vision/unit_tests/test_color.py‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,8 @@ def test_color_annotation_from_pb(self):
9696
dominant_colors=dominant_colors)
9797

9898
color_info = self._get_target_class()
99-
image_properties_result = color_info.from_pb(image_properties_pb)
99+
image_properties = color_info.from_pb(image_properties_pb)
100100

101-
self.assertEqual(len(image_properties_result), 1)
102-
image_properties = image_properties_result[0]
103101
self.assertEqual(image_properties.colors[0].pixel_fraction, 1.0)
104102
self.assertEqual(image_properties.colors[0].score, 1.0)
105103
self.assertEqual(image_properties.colors[0].color.red, 1.0)

0 commit comments

Comments
 (0)