Skip to content

Commit bafb197

Browse files
committed
Merge pull request #801 from tseaver/799-work_around_cannot_bind_fields_query_param
Fix #799: Don't pass 'fields' query param to possibly non-existing subscription.
2 parents 9c7f1fd + 9bc46c4 commit bafb197

2 files changed

Lines changed: 3 additions & 5 deletions

File tree

gcloud/pubsub/subscription.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,7 @@ def exists(self):
107107
"""
108108
conn = self.topic.connection
109109
try:
110-
conn.api_request(method='GET',
111-
path=self.path,
112-
query_params={'fields': 'name'})
110+
conn.api_request(method='GET', path=self.path)
113111
except NotFound:
114112
return False
115113
else:

gcloud/pubsub/test_subscription.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ def test_exists_miss(self):
171171
req = conn._requested[0]
172172
self.assertEqual(req['method'], 'GET')
173173
self.assertEqual(req['path'], '/%s' % SUB_PATH)
174-
self.assertEqual(req['query_params'], {'fields': 'name'})
174+
self.assertEqual(req.get('query_params'), None)
175175

176176
def test_exists_hit(self):
177177
PROJECT = 'PROJECT'
@@ -187,7 +187,7 @@ def test_exists_hit(self):
187187
req = conn._requested[0]
188188
self.assertEqual(req['method'], 'GET')
189189
self.assertEqual(req['path'], '/%s' % SUB_PATH)
190-
self.assertEqual(req['query_params'], {'fields': 'name'})
190+
self.assertEqual(req.get('query_params'), None)
191191

192192
def test_reload(self):
193193
PROJECT = 'PROJECT'

0 commit comments

Comments
 (0)