Revert "api_core: Make PageIterator.item_to_value public. (#4702)" (#4731)

Author: Jon Wayne Parrott

packages/google-cloud-datastore/google/cloud/datastore/query.py

@@ -515,7 +515,7 @@ def _next_page(self):
             query=query_pb,
         )
         entity_pbs = self._process_query_results(response_pb)
-        return page_iterator.Page(self, entity_pbs, self.item_to_value)
+        return page_iterator.Page(self, entity_pbs, self._item_to_value)
 
 
 def _pb_from_query(query):

packages/google-cloud-datastore/tests/unit/test_query.py

@@ -361,6 +361,7 @@ def test_constructor_defaults(self):
 
         self.assertFalse(iterator._started)
         self.assertIs(iterator.client, client)
+        self.assertIsNotNone(iterator._item_to_value)
         self.assertIsNone(iterator.max_results)
         self.assertEqual(iterator.page_number, 0)
         self.assertIsNone(iterator.next_page_token,)
@@ -383,6 +384,7 @@ def test_constructor_explicit(self):
 
         self.assertFalse(iterator._started)
         self.assertIs(iterator.client, client)
+        self.assertIsNotNone(iterator._item_to_value)
         self.assertEqual(iterator.max_results, limit)
         self.assertEqual(iterator.page_number, 0)
         self.assertEqual(iterator.next_page_token, start_cursor)