Skip to content

Commit 940fce6

Browse files
committed
Updating system test and docs for list_metrics() change.
1 parent cd6265f commit 940fce6

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

docs/logging-usage.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ List all metrics for a project:
171171

172172
>>> from google.cloud import logging
173173
>>> client = logging.Client()
174-
>>> metrics, token = client.list_metrics()
174+
>>> metrics = list(client.list_metrics())
175175
>>> len(metrics)
176176
1
177177
>>> metric = metrics[0]

system_tests/logging_.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -267,12 +267,12 @@ def test_list_metrics(self):
267267
metric = Config.CLIENT.metric(
268268
METRIC_NAME, DEFAULT_FILTER, DEFAULT_DESCRIPTION)
269269
self.assertFalse(metric.exists())
270-
before_metrics, _ = Config.CLIENT.list_metrics()
270+
before_metrics = list(Config.CLIENT.list_metrics())
271271
before_names = set(metric.name for metric in before_metrics)
272272
metric.create()
273273
self.to_delete.append(metric)
274274
self.assertTrue(metric.exists())
275-
after_metrics, _ = Config.CLIENT.list_metrics()
275+
after_metrics = list(Config.CLIENT.list_metrics())
276276
after_names = set(metric.name for metric in after_metrics)
277277
self.assertEqual(after_names - before_names,
278278
set([METRIC_NAME]))
@@ -304,7 +304,7 @@ def test_update_metric(self):
304304
metric.filter_ = NEW_FILTER
305305
metric.description = NEW_DESCRIPTION
306306
metric.update()
307-
after_metrics, _ = Config.CLIENT.list_metrics()
307+
after_metrics = list(Config.CLIENT.list_metrics())
308308
after_info = {metric.name: metric for metric in after_metrics}
309309
after = after_info[METRIC_NAME]
310310
self.assertEqual(after.filter_, NEW_FILTER)

0 commit comments

Comments
 (0)