Skip to content

Commit 91c56a7

Browse files
authored
Merge pull request #3033 from dhermes/no-more-connection-modules
Renaming all remaining connection.py modules as _http.py.
2 parents abf496e + c957bb9 commit 91c56a7

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

packages/google-cloud-monitoring/google/cloud/monitoring/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"""Google Stackdriver Monitoring API wrapper."""
1616

1717
from google.cloud.monitoring.client import Client
18-
from google.cloud.monitoring.connection import Connection
1918
from google.cloud.monitoring.group import Group
2019
from google.cloud.monitoring.label import LabelDescriptor
2120
from google.cloud.monitoring.label import LabelValueType
@@ -33,7 +32,6 @@
3332

3433
__all__ = (
3534
'Client',
36-
'Connection',
3735
'Group',
3836
'LabelDescriptor', 'LabelValueType',
3937
'Metric', 'MetricDescriptor', 'MetricKind', 'ValueType',

packages/google-cloud-monitoring/google/cloud/monitoring/connection.py renamed to packages/google-cloud-monitoring/google/cloud/monitoring/_http.py

File renamed without changes.

packages/google-cloud-monitoring/google/cloud/monitoring/client.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@
3232

3333
from google.cloud._helpers import _datetime_to_rfc3339
3434
from google.cloud.client import ClientWithProject
35-
from google.cloud.monitoring.connection import Connection
35+
36+
from google.cloud.monitoring._http import Connection
3637
from google.cloud.monitoring.group import Group
3738
from google.cloud.monitoring.metric import Metric
3839
from google.cloud.monitoring.metric import MetricDescriptor
@@ -44,6 +45,7 @@
4445
from google.cloud.monitoring.timeseries import Point
4546
from google.cloud.monitoring.timeseries import TimeSeries
4647

48+
4749
_UTCNOW = datetime.datetime.utcnow # To be replaced by tests.
4850

4951

packages/google-cloud-monitoring/unit_tests/test_connection.py renamed to packages/google-cloud-monitoring/unit_tests/test__http.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ class TestConnection(unittest.TestCase):
1919

2020
@staticmethod
2121
def _get_target_class():
22-
from google.cloud.monitoring.connection import Connection
22+
from google.cloud.monitoring._http import Connection
2323

2424
return Connection
2525

0 commit comments

Comments
 (0)