fix(resourcemanager): update test assertion and core version pin (#10095

) * Adjust request params assertion in test (timeout) * Bump pin for core dependency This is to assure that Connection object from core supports timeouts.
googleapis · Jan 10, 2020 · 755eb36 · 755eb36
1 parent b144fbf
commit 755eb36
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/resource_manager/setup.py b/resource_manager/setup.py
@@ -29,7 +29,7 @@
 # 'Development Status :: 5 - Production/Stable'
 release_status = 'Development Status :: 3 - Alpha'
 dependencies = [
-    "google-cloud-core >= 1.0.3, < 2.0dev",
+    "google-cloud-core >= 1.1.0, < 2.0dev",
 ]
 extras = {
 }

diff --git a/resource_manager/tests/unit/test__http.py b/resource_manager/tests/unit/test__http.py
@@ -74,5 +74,9 @@ def test_extra_headers(self):
         }
         expected_uri = conn.build_api_url("/rainbow")
         http.request.assert_called_once_with(
-            data=req_data, headers=expected_headers, method="GET", url=expected_uri
+            data=req_data,
+            headers=expected_headers,
+            method="GET",
+            url=expected_uri,
+            timeout=None,
         )