Skip to content

Commit 71c13e0

Browse files
authored
fix: corner case fix for empty request generated test (#801)
Fix for #791
1 parent a5b5e7b commit 71c13e0

File tree

1 file changed

+3
-4
lines changed
  • packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service

1 file changed

+3
-4
lines changed

packages/gapic-generator/gapic/templates/%namespace/%name_%version/%sub/services/%service/client.py.j2

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -359,14 +359,13 @@ class {{ service.client_name }}(metaclass={{ service.client_name }}Meta):
359359

360360
{% endif -%}
361361
{% if method.input.ident.package != method.ident.package -%} {# request lives in a different package, so there is no proto wrapper #}
362-
# The request isn't a proto-plus wrapped type,
363-
# so it must be constructed via keyword expansion.
364362
if isinstance(request, dict):
363+
# The request isn't a proto-plus wrapped type,
364+
# so it must be constructed via keyword expansion.
365365
request = {{ method.input.ident }}(**request)
366-
{% if method.flattened_fields -%}{# Cross-package req and flattened fields #}
367366
elif not request:
367+
# Null request, just make one.
368368
request = {{ method.input.ident }}()
369-
{% endif -%}{# Cross-package req and flattened fields #}
370369
{%- else %}
371370
# Minor optimization to avoid making a copy if the user passes
372371
# in a {{ method.input.ident }}.

0 commit comments

Comments
 (0)