Skip to content

Commit 56bc428

Browse files
committed
Using storage.googleapis.com in public URL.
commondatastorage.googleapis.com has long been out of use.
1 parent a9bc7fe commit 56bc428

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

gcloud/storage/blob.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ def public_url(self):
162162
:returns: The public URL for this blob.
163163
"""
164164
return '{storage_base_url}/{bucket_name}/{quoted_name}'.format(
165-
storage_base_url='http://commondatastorage.googleapis.com',
165+
storage_base_url='https://storage.googleapis.com',
166166
bucket_name=self.bucket.name,
167167
quoted_name=quote(self.name, safe=''))
168168

gcloud/storage/test_blob.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ def test_public_url(self):
143143
bucket = _Bucket(connection)
144144
blob = self._makeOne(BLOB_NAME, bucket=bucket)
145145
self.assertEqual(blob.public_url,
146-
'http://commondatastorage.googleapis.com/name/%s' %
146+
'https://storage.googleapis.com/name/%s' %
147147
BLOB_NAME)
148148

149149
def test_public_url_w_slash_in_name(self):
@@ -153,7 +153,7 @@ def test_public_url_w_slash_in_name(self):
153153
blob = self._makeOne(BLOB_NAME, bucket=bucket)
154154
self.assertEqual(
155155
blob.public_url,
156-
'http://commondatastorage.googleapis.com/name/parent%2Fchild')
156+
'https://storage.googleapis.com/name/parent%2Fchild')
157157

158158
def _basic_generate_signed_url_helper(self, credentials=None):
159159
from gcloud._testing import _Monkey

0 commit comments

Comments
 (0)