Fix __eq__ and __ne__. (#3765)

Author: lukesneeringer

packages/google-cloud-datastore/google/cloud/datastore/entity.py

@@ -146,7 +146,7 @@ def __eq__(self, other):
         :returns: True if the entities compare equal, else False.
         """
         if not isinstance(other, Entity):
-            return False
+            return NotImplemented
 
         return (self.key == other.key and
                 self.exclude_from_indexes == other.exclude_from_indexes and
@@ -162,7 +162,7 @@ def __ne__(self, other):
         :rtype: bool
         :returns: False if the entities compare equal, else True.
         """
-        return not self.__eq__(other)
+        return not self == other
 
     @property
     def kind(self):

packages/google-cloud-datastore/google/cloud/datastore/helpers.py

@@ -454,7 +454,7 @@ def __eq__(self, other):
         :returns: True if the points compare equal, else False.
         """
         if not isinstance(other, GeoPoint):
-            return False
+            return NotImplemented
 
         return (self.latitude == other.latitude and
                 self.longitude == other.longitude)
@@ -465,4 +465,4 @@ def __ne__(self, other):
         :rtype: bool
         :returns: False if the points compare equal, else True.
         """
-        return not self.__eq__(other)
+        return not self == other

packages/google-cloud-datastore/google/cloud/datastore/key.py

@@ -123,7 +123,7 @@ def __eq__(self, other):
         :returns: True if the keys compare equal, else False.
         """
         if not isinstance(other, Key):
-            return False
+            return NotImplemented
 
         if self.is_partial or other.is_partial:
             return False
@@ -143,7 +143,7 @@ def __ne__(self, other):
         :rtype: bool
         :returns: False if the keys compare equal, else True.
         """
-        return not self.__eq__(other)
+        return not self == other
 
     def __hash__(self):
         """Hash a keys for use in a dictionary lookp.