From 404df6f18e9bb9cb40de544e730330a81f7a3d0d Mon Sep 17 00:00:00 2001 From: Yoshi Automation Bot Date: Thu, 12 Dec 2019 09:56:27 -0800 Subject: [PATCH] docs(monitoring): tweak formatting in proto comments (via synth) (#9966) --- .../cloud/monitoring_v3/proto/alert.proto | 4 +- .../cloud/monitoring_v3/proto/service.proto | 2 +- .../cloud/monitoring_v3/proto/service_pb2.py | 2 +- .../cloud/monitoring_v3/proto/uptime.proto | 42 +++++++++---------- .../google-cloud-monitoring/synth.metadata | 10 ++--- 5 files changed, 30 insertions(+), 30 deletions(-) diff --git a/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/alert.proto b/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/alert.proto index a4ea225d5772..fc811a01c48d 100644 --- a/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/alert.proto +++ b/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/alert.proto @@ -302,8 +302,8 @@ message AlertPolicy { // conditions. repeated Condition conditions = 12; - // How to combine the results of multiple conditions - // to determine if an incident should be opened. + // How to combine the results of multiple conditions to determine if an + // incident should be opened. ConditionCombinerType combiner = 6; // Whether or not the policy is enabled. On write, the default interpretation diff --git a/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/service.proto b/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/service.proto index 7de203319af1..b0daa551e80b 100644 --- a/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/service.proto +++ b/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/service.proto @@ -151,7 +151,7 @@ message ServiceLevelObjective { ServiceLevelIndicator service_level_indicator = 3; // The fraction of service that must be good in order for this objective to be - // met. `0 < goal <= 1`. + // met. `0 < goal <= 0.999`. double goal = 4; // The time period over which the objective will be evaluated. diff --git a/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/service_pb2.py b/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/service_pb2.py index 257a6dbc9e84..242c47799f62 100644 --- a/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/service_pb2.py +++ b/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/service_pb2.py @@ -1710,7 +1710,7 @@ single aspect of service quality. goal: The fraction of service that must be good in order for this - objective to be met. ``0 < goal <= 1``. + objective to be met. ``0 < goal <= 0.999``. period: The time period over which the objective will be evaluated. rolling_period: diff --git a/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/uptime.proto b/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/uptime.proto index eb424e971517..780a2578dff3 100644 --- a/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/uptime.proto +++ b/packages/google-cloud-monitoring/google/cloud/monitoring_v3/proto/uptime.proto @@ -83,27 +83,6 @@ message InternalChecker { State state = 7; } -// The regions from which an Uptime check can be run. -enum UptimeCheckRegion { - // Default value if no region is specified. Will result in Uptime checks - // running from all regions. - REGION_UNSPECIFIED = 0; - - // Allows checks to run from locations within the United States of America. - USA = 1; - - // Allows checks to run from locations within the continent of Europe. - EUROPE = 2; - - // Allows checks to run from locations within the continent of South - // America. - SOUTH_AMERICA = 3; - - // Allows checks to run from locations within the Asia Pacific area (ex: - // Singapore). - ASIA_PACIFIC = 4; -} - // This message configures which resources and services to monitor for // availability. message UptimeCheckConfig { @@ -304,6 +283,27 @@ message UptimeCheckConfig { repeated InternalChecker internal_checkers = 14 [deprecated = true]; } +// The regions from which an Uptime check can be run. +enum UptimeCheckRegion { + // Default value if no region is specified. Will result in Uptime checks + // running from all regions. + REGION_UNSPECIFIED = 0; + + // Allows checks to run from locations within the United States of America. + USA = 1; + + // Allows checks to run from locations within the continent of Europe. + EUROPE = 2; + + // Allows checks to run from locations within the continent of South + // America. + SOUTH_AMERICA = 3; + + // Allows checks to run from locations within the Asia Pacific area (ex: + // Singapore). + ASIA_PACIFIC = 4; +} + // Contains the region, location, and list of IP // addresses where checkers in the location run from. message UptimeCheckIp { diff --git a/packages/google-cloud-monitoring/synth.metadata b/packages/google-cloud-monitoring/synth.metadata index 9b8551077f19..2e5bff180d6b 100644 --- a/packages/google-cloud-monitoring/synth.metadata +++ b/packages/google-cloud-monitoring/synth.metadata @@ -1,19 +1,19 @@ { - "updateTime": "2019-11-19T13:28:35.257420Z", + "updateTime": "2019-12-12T13:21:41.023609Z", "sources": [ { "generator": { "name": "artman", - "version": "0.42.1", - "dockerImage": "googleapis/artman@sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57" + "version": "0.42.3", + "dockerImage": "googleapis/artman@sha256:feed210b5723c6f524b52ef6d7740a030f2d1a8f7c29a71c5e5b4481ceaad7f5" } }, { "git": { "name": "googleapis", "remote": "https://github.com/googleapis/googleapis.git", - "sha": "d8dd7fe8d5304f7bd1c52207703d7f27d5328c5a", - "internalRef": "281088257" + "sha": "19c4589a3cb44b3679f7b3fba88365b3d055d5f8", + "internalRef": "285013366" } }, {