Skip to content

Commit 11d33bb

Browse files
committed
Check for specific exception.
1 parent 878fb58 commit 11d33bb

File tree

2 files changed

+8
-8
lines changed

2 files changed

+8
-8
lines changed

bigtable/google/cloud/bigtable/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"""Scope for reading table data."""
6767

6868
# NOTE: 'grpc.max_message_length' will no longer be recognized in
69-
# grpcio 1.1 and later.
69+
# grpcio 1.1 and later.
7070
_MAX_MSG_LENGTH_100MB = 100 * 1024 * 1024
7171
_GRPC_MAX_LENGTH_OPTIONS = (
7272
('grpc.max_message_length', _MAX_MSG_LENGTH_100MB),

system_tests/bigtable.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
from google.cloud.bigtable.row_data import Cell
3131
from google.cloud.bigtable.row_data import PartialRowData
3232
from google.cloud.environment_vars import BIGTABLE_EMULATOR
33+
from grpc._channel import _Rendezvous
3334

3435
from retry import RetryErrors
3536
from retry import RetryResult
@@ -361,7 +362,7 @@ def test_read_large_cell_limit(self):
361362
self.rows_to_delete.append(row)
362363

363364
number_of_bytes = 10 * 1024 * 1024
364-
data = '1' * number_of_bytes # 10MB of 1's.
365+
data = b'1' * number_of_bytes # 10MB of 1's.
365366
row.set_cell(COLUMN_FAMILY_ID1, COL_NAME1, data)
366367
row.commit()
367368

@@ -378,23 +379,22 @@ def test_read_large_cells_over_limit(self):
378379
row = self._table.row(ROW_KEY)
379380
self.rows_to_delete.append(row)
380381

381-
data = '1' * 51 * 1024 * 1024 # 51MB.
382+
data = b'1' * 51 * 1024 * 1024 # 51MB.
382383
row.set_cell(COLUMN_FAMILY_ID1, COL_NAME1, data)
383384
row.commit()
384385
row.set_cell(COLUMN_FAMILY_ID1, COL_NAME1, data)
385386
row.commit()
386387

387-
with self.assertRaises(Exception):
388-
partial_row_data = self._table.read_row(ROW_KEY)
389-
388+
with self.assertRaises(_Rendezvous):
389+
self._table.read_row(ROW_KEY)
390390

391391
def test_read_large_cell_over_limit(self):
392392
row = self._table.row(ROW_KEY)
393393
self.rows_to_delete.append(row)
394394

395-
data = '1' * 101 * 1024 * 1024 # 11MB of 1's.
395+
data = b'1' * 101 * 1024 * 1024 # 101MB of 1's.
396396
row.set_cell(COLUMN_FAMILY_ID1, COL_NAME1, data)
397-
with self.assertRaises(Exception):
397+
with self.assertRaises(_Rendezvous):
398398
row.commit()
399399

400400
def test_read_row(self):

0 commit comments

Comments
 (0)