Skip to content

Commit 040325b

Browse files
committed
Updating storage system test after Iterator refactor.
1 parent 19802e8 commit 040325b

File tree

1 file changed

+12
-17
lines changed

1 file changed

+12
-17
lines changed

system_tests/storage.py

Lines changed: 12 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -257,14 +257,13 @@ def test_paginate_files(self):
257257
truncation_size = 1
258258
count = len(self.FILENAMES) - truncation_size
259259
iterator = self.bucket.list_blobs(max_results=count)
260-
response = iterator.get_next_page_response()
261-
blobs = list(iterator.get_items_from_response(response))
260+
iterator._update_page()
261+
blobs = list(iterator.page)
262262
self.assertEqual(len(blobs), count)
263-
self.assertEqual(iterator.page_number, 1)
264263
self.assertIsNotNone(iterator.next_page_token)
265264

266-
response = iterator.get_next_page_response()
267-
last_blobs = list(iterator.get_items_from_response(response))
265+
iterator._update_page()
266+
last_blobs = list(iterator.page)
268267
self.assertEqual(len(last_blobs), truncation_size)
269268

270269

@@ -302,20 +301,18 @@ def tearDownClass(cls):
302301
@RetryErrors(unittest.TestCase.failureException)
303302
def test_root_level_w_delimiter(self):
304303
iterator = self.bucket.list_blobs(delimiter='/')
305-
response = iterator.get_next_page_response()
306-
blobs = list(iterator.get_items_from_response(response))
304+
iterator._update_page()
305+
blobs = list(iterator.page)
307306
self.assertEqual([blob.name for blob in blobs], ['file01.txt'])
308-
self.assertEqual(iterator.page_number, 1)
309307
self.assertIsNone(iterator.next_page_token)
310308
self.assertEqual(iterator.prefixes, set(['parent/']))
311309

312310
@RetryErrors(unittest.TestCase.failureException)
313311
def test_first_level(self):
314312
iterator = self.bucket.list_blobs(delimiter='/', prefix='parent/')
315-
response = iterator.get_next_page_response()
316-
blobs = list(iterator.get_items_from_response(response))
313+
iterator._update_page()
314+
blobs = list(iterator.page)
317315
self.assertEqual([blob.name for blob in blobs], ['parent/file11.txt'])
318-
self.assertEqual(iterator.page_number, 1)
319316
self.assertIsNone(iterator.next_page_token)
320317
self.assertEqual(iterator.prefixes, set(['parent/child/']))
321318

@@ -328,11 +325,10 @@ def test_second_level(self):
328325

329326
iterator = self.bucket.list_blobs(delimiter='/',
330327
prefix='parent/child/')
331-
response = iterator.get_next_page_response()
332-
blobs = list(iterator.get_items_from_response(response))
328+
iterator._update_page()
329+
blobs = list(iterator.page)
333330
self.assertEqual([blob.name for blob in blobs],
334331
expected_names)
335-
self.assertEqual(iterator.page_number, 1)
336332
self.assertIsNone(iterator.next_page_token)
337333
self.assertEqual(iterator.prefixes,
338334
set(['parent/child/grand/', 'parent/child/other/']))
@@ -345,11 +341,10 @@ def test_third_level(self):
345341
# Exercise a layer deeper to illustrate this.
346342
iterator = self.bucket.list_blobs(delimiter='/',
347343
prefix='parent/child/grand/')
348-
response = iterator.get_next_page_response()
349-
blobs = list(iterator.get_items_from_response(response))
344+
iterator._update_page()
345+
blobs = list(iterator.page)
350346
self.assertEqual([blob.name for blob in blobs],
351347
['parent/child/grand/file31.txt'])
352-
self.assertEqual(iterator.page_number, 1)
353348
self.assertIsNone(iterator.next_page_token)
354349
self.assertEqual(iterator.prefixes, set())
355350

0 commit comments

Comments
 (0)