-
Notifications
You must be signed in to change notification settings - Fork 641
compute: create default firewall rules #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
callmehiphop
merged 1 commit into
googleapis:master
from
stephenplusplus:spp--compute-http-server-firewall
Oct 19, 2015
Merged
compute: create default firewall rules #915
callmehiphop
merged 1 commit into
googleapis:master
from
stephenplusplus:spp--compute-http-server-firewall
Oct 19, 2015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
Contributor
Author
|
@callmehiphop PTAL |
callmehiphop
added a commit
that referenced
this pull request
Oct 19, 2015
…-firewall compute: create default firewall rules
Contributor
|
Looks good :) |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
Source-Author: Takashi Matsuo <tmatsuo@google.com> Source-Date: Fri Oct 2 12:13:27 2020 -0700 Source-Repo: googleapis/synthtool Source-Sha: 0c868d49b8e05bc1f299bc773df9eb4ef9ed96e9 Source-Link: googleapis/synthtool@0c868d4
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
- [ ] Regenerate this pull request now. Committer: @summer-ji-eng PiperOrigin-RevId: 424244721 Source-Link: googleapis/googleapis@4b6b01f Source-Link: googleapis/googleapis-gen@8ac83fb Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGFjODNmYmE2MDZkMDA4YzdlOGE0MmU3ZDU1YjY1OTZlYzRiZTM1ZiJ9
GautamSharda
added a commit
that referenced
this pull request
Feb 2, 2026
* chore: fix lint failures Source-Link: googleapis/synthtool@36ebc33 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:1c50961ec998cd24968d5b2628e8d88a36b612ea881e71bfd171c93cc9d08b9e * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Gautam Sharda <57648023+GautamSharda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: compute
Issues related to the Compute Engine API.
cla: yes
This human has signed the Contributor License Agreement.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related http://stackoverflow.com/questions/31509722/how-do-i-enable-http-traffic-for-gce-instance-templates
Fixes stephenplusplus/gcloud-deploy#4
We had a "maybe-bug" in our code that could lead to a user thinking they made a VM that accepts HTTP and/or HTTPS connections, but in actuality doesn't.
My theory about how the Dev Console UI works:
If you create an Instance and select "Allow HTTP traffic" and/or "Allow HTTPS traffic", it will create firewall rules in the default network:
default-allow-httpanddefault-allow-https. The VM is created with tags to matchhttp-serverandhttps-server, which are the target tags on the firewall rules.When I developed the behavior of
zone.createVM()that acceptsconfig.http = trueandconfig.https = true, I assumed all project's networks had these firewall rules by default. But, if my theory is right, I only had them because I used the UI to create an http/https VM before, so my project had the rules.So, this PR will attempt to create
default-allow-httpanddefault-allow-https(when that functionality is asked for), and if they already exist, it just moves on and creates the VM. If they don't exist, it creates them, then the VM. In other words, this should basically work like the Dev Console UI does (if my theory is correct).