core: use custom error types #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
force-pushed
the
spp--custom-errors
branch
2 times, most recently
from
0a15cc1 to
5e78c8b
Compare
| 'Please verify you are authorized with this property available.' | ||
| ].join(' '); | ||
|
|
||
| assert.strictEqual(err.name, 'SigningError'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
I love it! |
|
Woo! Looks like I have some rebasing ahead of me! |
stephenplusplus
force-pushed
the
spp--custom-errors
branch
from
5e78c8b to
5b4d509
Compare
callmehiphop
added a commit
that referenced
this pull request
Sep 23, 2015
core: use custom error types
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
* chore: migrate to owl bot * chore: copy files from googleapis-gen fb91803ccef5d7c695139b22788b309e2197856b * chore: run the post processor * 🦉 Updates from OwlBot Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
gcf-owl-bot bot
added a commit
that referenced
this pull request
Feb 29, 2024
Source-Link: googleapis/googleapis@0df0f51 Source-Link: googleapis/googleapis-gen@b0b8f14 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6ImIwYjhmMTQ3YTc3MTYyYmJjNjAzY2MxZTA0NzUyYTM2MjFlMTJlYjUifQ==
sofisl
pushed a commit
that referenced
this pull request
Mar 4, 2024
…#5100) * feat: Update Compute Engine API to revision 20240220 (#886) Source-Link: googleapis/googleapis@0df0f51 Source-Link: googleapis/googleapis-gen@b0b8f14 Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWNvbXB1dGUvLk93bEJvdC55YW1sIiwiaCI6ImIwYjhmMTQ3YTc3MTYyYmJjNjAzY2MxZTA0NzUyYTM2MjFlMTJlYjUifQ== * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #859
@callmehiphop let me know how I did!