datastore: throw if an unrecognized commit method is given #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenplusplus
added
enhancement
api: datastore
googlebot
added
the
cla: yes
stephenplusplus
force-pushed
the
spp--datastore-auto_insert_id
branch
from
3b538b2 to
d262968
Compare
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
callmehiphop
added a commit
that referenced
this pull request
Sep 23, 2015
…rt_id datastore: throw if an unrecognized commit method is given
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* docs: recommend AnalyzeContent for future users PiperOrigin-RevId: 402401837 Source-Link: googleapis/googleapis@16ff813 Source-Link: googleapis/googleapis-gen@c9e6ac2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzllNmFjMjVkNWUzMDkxNzBmMTgwNWJmOGVhMzgyYThiMjNkZWU2NSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
Fixes googleapis/cloud-profiler-nodejs#879, take two of googleapis/cloud-profiler-nodejs#883 with correct commit message. This caused an issue where the proto definitions in `protos/` are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos with `npm run protos`, however this fails because the third_party directory was removed in googleapis/cloud-profiler-nodejs#486. To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused `protos/` directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
Fixes googleapis/cloud-profiler-nodejs#879, take two of googleapis/cloud-profiler-nodejs#883 with correct commit message. This caused an issue where the proto definitions in `protos/` are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos with `npm run protos`, however this fails because the third_party directory was removed in googleapis/cloud-profiler-nodejs#486. To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused `protos/` directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
Fixes googleapis/cloud-profiler-nodejs#879, take two of googleapis/cloud-profiler-nodejs#883 with correct commit message. This caused an issue where the proto definitions in `protos/` are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos with `npm run protos`, however this fails because the third_party directory was removed in googleapis/cloud-profiler-nodejs#486. To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused `protos/` directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.
sofisl
pushed a commit
that referenced
this pull request
Jan 27, 2026
Fixes googleapis/cloud-profiler-nodejs#879, take two of googleapis/cloud-profiler-nodejs#883 with correct commit message. This caused an issue where the proto definitions in `protos/` are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos with `npm run protos`, however this fails because the third_party directory was removed in googleapis/cloud-profiler-nodejs#486. To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused `protos/` directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.
sofisl
pushed a commit
that referenced
this pull request
Jan 28, 2026
Fixes googleapis/cloud-profiler-nodejs#879, take two of googleapis/cloud-profiler-nodejs#883 with correct commit message. This caused an issue where the proto definitions in `protos/` are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos with `npm run protos`, however this fails because the third_party directory was removed in googleapis/cloud-profiler-nodejs#486. To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused `protos/` directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.
sofisl
pushed a commit
that referenced
this pull request
Jan 28, 2026
Fixes googleapis/cloud-profiler-nodejs#879, take two of googleapis/cloud-profiler-nodejs#883 with correct commit message. This caused an issue where the proto definitions in `protos/` are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos with `npm run protos`, however this fails because the third_party directory was removed in googleapis/cloud-profiler-nodejs#486. To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused `protos/` directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
sofisl
pushed a commit
that referenced
this pull request
Jan 29, 2026
Fixes googleapis/cloud-profiler-nodejs#879, take two of googleapis/cloud-profiler-nodejs#883 with correct commit message. This caused an issue where the proto definitions in `protos/` are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos with `npm run protos`, however this fails because the third_party directory was removed in googleapis/cloud-profiler-nodejs#486. To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused `protos/` directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.
sofisl
pushed a commit
that referenced
this pull request
Jan 29, 2026
Fixes googleapis/cloud-profiler-nodejs#879, take two of googleapis/cloud-profiler-nodejs#883 with correct commit message. This caused an issue where the proto definitions in `protos/` are incompatible with those returned from pprof. The fix I assumed was to regenerate the protos with `npm run protos`, however this fails because the third_party directory was removed in googleapis/cloud-profiler-nodejs#486. To make things work, I instead just imported the same proto definitions from pprof library. I will delete the now unused `protos/` directory for the next major version release as someone could theoretically have been importing them from build, just to be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #883
This also did a sweep over the structure of the code, hopefully making it more understandable rather than fancy.