FIX(storage): throw Error if bucket name is not passed to bucket constru... #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/storage/index.js
Outdated
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
Styling comments, otherwise LGTM. |
Contributor
Author
|
Done! |
rakyll
pushed a commit
that referenced
this pull request
Jul 30, 2014
FIX(storage): throw Error if bucket name is not passed to bucket constru...
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 5, 2022
This was referenced Oct 5, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 8, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 11, 2022
This was referenced Oct 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
* chore: ignore package-log.json * remove locky * renovateeee
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
…or (#68) Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [ts-loader](https://togithub.com/TypeStrong/ts-loader) | devDependencies | major | [`^6.2.1` -> `^7.0.0`](https://renovatebot.com/diffs/npm/ts-loader/6.2.2/7.0.0) | --- ### Release Notes <details> <summary>TypeStrong/ts-loader</summary> ### [`v7.0.0`](https://togithub.com/TypeStrong/ts-loader/blob/master/CHANGELOG.md#v700) [Compare Source](https://togithub.com/TypeStrong/ts-loader/compare/v6.2.2...v7.0.0) - [Project reference support enhancements](https://togithub.com/TypeStrong/ts-loader/pull/1076) - thanks [@​sheetalkamat](https://togithub.com/sheetalkamat)! - Following the end of life of Node 8, `ts-loader` no longer supports Node 8 **BREAKING CHANGE** </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/nodejs-recommender).
This was referenced Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [webpack-cli](https://togithub.com/webpack/webpack-cli) | devDependencies | major | [`^3.3.11` -> `^4.0.0`](https://renovatebot.com/diffs/npm/webpack-cli/3.3.12/4.0.0) | --- ### Release Notes <details> <summary>webpack/webpack-cli</summary> ### [`v4.0.0`](https://togithub.com/webpack/webpack-cli/blob/master/CHANGELOG.md#​400-httpsgithubcomwebpackwebpack-clicomparewebpack-cli400-rc1webpack-cli400-2020-10-10) [Compare Source](https://togithub.com/webpack/webpack-cli/compare/v3.3.12...webpack-cli@4.0.0) ##### Bug Fixes - add compilation lifecycle in watch instance ([#​1903](https://togithub.com/webpack/webpack-cli/issues/1903)) ([02b6d21](https://togithub.com/webpack/webpack-cli/commit/02b6d21eaa20166a7ed37816de716b8fc22b756a)) - cleanup `package-utils` package ([#​1822](https://togithub.com/webpack/webpack-cli/issues/1822)) ([fd5b92b](https://togithub.com/webpack/webpack-cli/commit/fd5b92b3cd40361daec5bf4486e455a41f4c9738)) - cli-executer supplies args further up ([#​1904](https://togithub.com/webpack/webpack-cli/issues/1904)) ([097564a](https://togithub.com/webpack/webpack-cli/commit/097564a851b36b63e0a6bf88144997ef65aa057a)) - exit code for validation errors ([59f6303](https://togithub.com/webpack/webpack-cli/commit/59f63037fcbdbb8934b578b9adf5725bc4ae1235)) - exit process in case of schema errors ([71e89b4](https://togithub.com/webpack/webpack-cli/commit/71e89b4092d953ea587cc4f606451ab78cbcdb93)) ##### Features - assign config paths in build dependencies in cache config ([#​1900](https://togithub.com/webpack/webpack-cli/issues/1900)) ([7e90f11](https://togithub.com/webpack/webpack-cli/commit/7e90f110b119f36ef9def4f66cf4e17ccf1438cd)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-memcache).
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
Committer: @alexander-fenster PiperOrigin-RevId: 372656503 Source-Link: googleapis/googleapis@6fa858c Source-Link: googleapis/googleapis-gen@d7c95df
4 tasks
This was referenced Nov 16, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [1.1.4](https://www.github.com/googleapis/nodejs-retail/compare/v1.1.3...v1.1.4) (2021-07-01) ### Bug Fixes * **deps:** require google-gax v2.17.0 ([#66](https://www.github.com/googleapis/nodejs-retail/issues/66)) ([94fd8a8](https://www.github.com/googleapis/nodejs-retail/commit/94fd8a842f4fc7cfb480e72d4b3375ec0293cc09)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 18, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
* chore: lock files maintenance * chore: lock files maintenance
sofisl
pushed a commit
that referenced
this pull request
Jan 26, 2023
autosynth cannot find the source of changes triggered by earlier changes in this
repository, or by version upgrades to tools such as linters.
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jul 23, 2025
- 'metadata' and 'status' events are meaningful and should be forwarded. - gRPC streaming results have 'cancel' method, this method call needs to be forwarded as well. Fixes #67
miguelvelezsa
pushed a commit
that referenced
this pull request
Sep 17, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 14, 2026
Since we are using a protobuf based transport, users need to format according to the protobuf docs rather than the JSON/REST docs. Ref: googleapis/nodejs-logging-winston#93
This was referenced Jan 14, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Jan 14, 2026
The draft release notes are in the GitHub UI. Fixes #67
GautamSharda
pushed a commit
that referenced
this pull request
Jan 20, 2026
The draft release notes are in the GitHub UI. Fixes #67
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 21, 2026
Since we are using a protobuf based transport, users need to format according to the protobuf docs rather than the JSON/REST docs. Ref: googleapis/nodejs-logging-winston#93
GautamSharda
pushed a commit
that referenced
this pull request
Jan 21, 2026
The draft release notes are in the GitHub UI. Fixes #67
4 tasks
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 28, 2026
miguelvelezsa
pushed a commit
that referenced
this pull request
Jan 29, 2026
GautamSharda
pushed a commit
that referenced
this pull request
Feb 2, 2026
The draft release notes are in the GitHub UI. Fixes #67
GautamSharda
pushed a commit
that referenced
this pull request
Feb 3, 2026
The draft release notes are in the GitHub UI. Fixes #67
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ctor.