Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle errors in read stream #443

Merged
merged 1 commit into from
Mar 11, 2015
Merged

handle errors in read stream #443

merged 1 commit into from
Mar 11, 2015

Conversation

stephenplusplus
Copy link
Contributor

Fixes #423

@ryanseys noticed we aren't passing raw HTTP responses through to util.handleResp like we do elsewhere in the library. This fixes that, though I wasn't able to reproduce the issue seen in #423 locally.

Recommended viewing: https://github.com/GoogleCloudPlatform/gcloud-node/pull/443/files?w=1

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2015
stephenplusplus
stephenplusplus reviewed Mar 11, 2015
View reviewed changes
lib/storage/file.js

.on('data', function(chunk) {
if (crc32c) {
localCrc32cHash = crc.calculate(chunk, localCrc32cHash);
localCrcHash = crc.calculate(chunk, localCrcHash);

This comment was marked as spam.

Sign in to view

@ryanseys
Copy link
Contributor

LGTM.

ryanseys added a commit that referenced this pull request Mar 11, 2015
@ryanseys
Merge pull request #443 from stephenplusplus/spp--storage-handle-errors
812870d 
handle errors in read stream
@ryanseys ryanseys merged commit 812870d into googleapis:master Mar 11, 2015
chingor13 pushed a commit that referenced this pull request Aug 22, 2022
@yoshi-automation
docs: add instructions for authenticating for system tests (#443)
202eca0 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/9943226b-8e9b-44fd-b025-446fc572242a/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@363fe30
@sofisl sofisl mentioned this pull request Sep 15, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Sep 15, 2022
@yoshi-automation
docs: updated code of conduct (includes update to actions) (#443)
f2c1554 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/313ec1b8-2bb0-49a2-a59d-9211defb7a66/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@89c849b
Source-Link: googleapis/synthtool@a783321
Source-Link: googleapis/synthtool@b7413d3
Source-Link: googleapis/synthtool@5f6ef0e
@sofisl sofisl mentioned this pull request Sep 16, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Sep 16, 2022
@gcf-owl-bot
chore: update gapic-generator-typescript to v1.3.2 (#443)
4c6b0c2 
Committer: @alexander-fenster
PiperOrigin-RevId: 372656503

Source-Link: googleapis/googleapis@6fa858c

Source-Link: googleapis/googleapis-gen@d7c95df
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@gcf-owl-bot
chore: update gapic-generator-typescript to v1.3.2 (#443)
2fbdbf0 
Committer: @alexander-fenster
PiperOrigin-RevId: 372656503

Source-Link: googleapis/googleapis@6fa858c

Source-Link: googleapis/googleapis-gen@d7c95df
@sofisl sofisl mentioned this pull request Oct 5, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 5, 2022
@gcf-owl-bot
chore: update gapic-generator-typescript to v1.3.2 (#443)
5daa381 
Committer: @alexander-fenster
PiperOrigin-RevId: 372656503

Source-Link: googleapis/googleapis@6fa858c

Source-Link: googleapis/googleapis-gen@d7c95df
@sofisl sofisl mentioned this pull request Oct 8, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this pull request Oct 8, 2022
@gcf-owl-bot
chore: update gapic-generator-typescript to v1.3.2 (#443)
561eb03 
Committer: @alexander-fenster
PiperOrigin-RevId: 372656503

Source-Link: googleapis/googleapis@6fa858c

Source-Link: googleapis/googleapis-gen@d7c95df
@sofisl sofisl mentioned this pull request Oct 11, 2022
Merged
4 tasks
@sofisl sofisl mentioned this pull request Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@yoshi-automation
build: track flaky tests for "nightly", add new secrets for tagging (#…
6c625d5 
…443)

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/a94ea37f-bfd6-4053-ac90-1b88b224a0b0/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@8cf6d28
sofisl pushed a commit that referenced this pull request Nov 10, 2022
@fhinkel
chore: add dev dependencies for cloud-rad ref docs (#443)
9b55319
@sofisl sofisl mentioned this pull request Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation
build(node): add KOKORO_BUILD_ARTIFACTS_SUBDIR to env (#443)
d4e2b3c 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/bfc25924-7584-48c7-bead-23b659b9a9b8/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@ba9918c
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
feat: add new analysis status and cvss version fields (#443)
35505be 
* feat: add new analysis status and cvss version fields

PiperOrigin-RevId: 477815955

Source-Link: googleapis/googleapis@57e38f0

Source-Link: googleapis/googleapis-gen@3a587e1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiM2E1ODdlMTQ3NTIxZmY5NGM2OGE3OTE2M2FhMTY4NTVkYjlhN2E4YyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@release-please
chore(main): release 4.4.0 (#444)
c34672a 
🤖 I have created a release *beep* *boop*
---


## [4.4.0](https://togithub.com/googleapis/nodejs-containeranalysis/compare/v4.3.0...v4.4.0) (2022-10-06)


### Features

* Add new analysis status and cvss version fields ([#443](https://togithub.com/googleapis/nodejs-containeranalysis/issues/443)) ([2b4db8e](https://togithub.com/googleapis/nodejs-containeranalysis/commit/2b4db8ee9859823e32de8256853429adf88cf207))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this pull request Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@yoshi-automation
docs: add instructions for authenticating for system tests (#443)
6f430c1 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/9943226b-8e9b-44fd-b025-446fc572242a/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@363fe30
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 11, 2022
@gcf-owl-bot
fix!: remove LRO mixin methods where not needed (#443)
2810a6f 
* test: use fully qualified request type name in tests

PiperOrigin-RevId: 475685359

Source-Link: googleapis/googleapis@7a12973

Source-Link: googleapis/googleapis-gen@370c729
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzcwYzcyOWUyYmEwNjJhMTY3NDQ5YzI3ODgyYmE1ZjM3OWM1YzM0ZCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot
fix(deps): update dependency gce-images to v3 (#443)
1e0a46d
This was referenced Nov 17, 2022
Merged
Merged
sofisl pushed a commit that referenced this pull request Nov 18, 2022
@gcf-owl-bot
build: add generated samples to .eslintignore (#443)
0efe9b0
sofisl pushed a commit that referenced this pull request Jan 24, 2023
@jmdobry
More word time offset samples. (#443)
bbcf872
sofisl pushed a commit that referenced this pull request Jan 25, 2023
@jmdobry
More word time offset samples. (#443)
b50984f
sofisl pushed a commit that referenced this pull request Sep 14, 2023
@yoshi-automation
refactor(nodejs): move build cop to flakybot (#443)
1f491b4 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/9fbf1b59-3d8b-4e65-9627-15e1bd83c6bf/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@57c23fa
@sofisl sofisl mentioned this pull request Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http response from google may not always has 'x-goog-hash' header
3 participants
@stephenplusplus @ryanseys @googlebot